On 08/18/2011 03:20 PM, Ciancetta, Jesse E. wrote:
Added:
incubator/rave/trunk/rave-portal/rave-selenium-tests/
incubator/rave/trunk/rave-portal/rave-selenium-tests/README.txt
incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-Gadgets-
Workout
incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-Login-Test
incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-New-
Account-Test
incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-OpenID-
Test
incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-Selenium-
Tests
I think its great to have these selenium tests but storing them under
rave-portal folder would not be my preference.
I'd rather would like to keep these separate from the direct code bases, like
for instance under: incubator/rave/trunk/etc/selenium-tests/
WDYT?
I agree that they should be moved, but I'm not sure that we necessarily need to
move them out from under rave-portal.
Are you thinking that they span more than just the rave-portal application code
(since the rave-portal code ends up running our shindig extension code) and as
such should be placed at a higher level? I guess that makes some sense to me,
but on the other hand it seems like the tests themselves are all about testing
the rave-portal web interface and the fact that they end up exercising some of
our shindig extension code seems like an implementation detail that we might
not need to represent in our SVN structure.
No, that wasn't my reasoning ;)
It was more related to the fact that the current "resources" under rave-portal/
are there to build the artifact and/or test it, from a sourcing and building
(e.g. Maven) perspective.
These selenium tests however (for now) have a completely different usage, to be
used manually from the Selenium IDE and thus so far unrelated to our build/test
infrastructure.
But, if/when we integrate selenium tests directly in the build process, have
these scripts in scope of the rave-portal does make sense.
So, thinking this through again, I'm actually fine keeping them in scope :)
But they should be moved down then indeed.
I'm thinking that putting them under rave-portal/test might be another
alternative:
incubator/rave/trunk/rave-portal/src/test/selenium
+1, this seems fine to me
or maybe /test/webapp/selenium to be more consistent with the structure under
the main tree (although I don’t think I like this as much):
incubator/rave/trunk/rave-portal/src/test/webapp/selenium
-0, I don't like it either
WDYT?
Regards,
Ate
