-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 If there are no objections, I'll go with
incubator/rave/trunk/rave-portal/src/test/selenium These have +1's from Jesse and Ate. Marlon On 8/18/11 11:59 AM, Ciancetta, Jesse E. wrote: >>> The tests have to be run manually and so should be easy to find >>> by downloaders (apart from reading the README). Ate's suggestion >>> is good, except I would prefer something like >>> "trunk/installation-tests/selenium" over etc. >>> >> LOL, I just agreed with Jesse these files might make sense to keep >> under rave-portal still, but then like under >> rave-portal/test/selenium for instance. >> >> But moving them under a separate integration-tests (I'd prefer not >> installation-tests) would be fine for me as well. > > I'd be ok with: > > incubator/rave/trunk/integration-tests/selenium > > but would still personally prefer: > > incubator/rave/trunk/rave-portal/src/test/selenium > > just because it seems like a logical place to put them (since the > other tests are there). I would think anyone who is familiar with > Maven wouldn’t have any trouble finding them -- and if they're > looking to execute integration tests then I assume they are doing > development, which I would assume means they are familiar with Maven > (or will need to become familiar in short order). > > So it sounds like Ate and I would be fine with either of the two > paths specified above (Ate please correct me if I'm wrong) so if > no-one else has an opinion, I'd be happy to leave it to Marlon to > pick whichever he prefers. > >> For the record: @Hippo we use headless selenium test scripts >> converted (automatically by Selenium) to Java and integrated as >> unit tests. I haven't set this up, and there are other/newer plans >> here in house to update this to a Cucumber driven tests >> configuration (http://cukes.info) through cuke4duke. >> >> >>> >>> Marlon >>> >>> >>> On 8/18/11 9:20 AM, Ciancetta, Jesse E. wrote: >>>>>> Added: >>>>>> incubator/rave/trunk/rave-portal/rave-selenium-tests/ >>>>>> incubator/rave/trunk/rave-portal/rave-selenium-tests/README.txt >>>>>> >>>>>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-Gadgets- >>>>> >>>>>> >>> Workout >>>>>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-Login-Test >>>>>> >>>>>> >>> >>>>>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-New- >>>>> Account-Test >>>>>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-OpenID- >>>>> >>>>>> >>> >>>>>> Test >>>>>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-Selenium- >>>>> >>>>>> >>> >>>>>> Tests >>>>>> >>>>> I think its great to have these selenium tests but storing >>>>> them under rave-portal folder would not be my preference. >>>>> >>>>> I'd rather would like to keep these separate from the direct >>>>> code bases, like for instance under: >>>>> incubator/rave/trunk/etc/selenium-tests/ >>>>> >>>>> WDYT? >>>> >>>> I agree that they should be moved, but I'm not sure that we >>>> necessarily need to move them out from under rave-portal. >>>> >>>> Are you thinking that they span more than just the rave-portal >>>> application code (since the rave-portal code ends up running >>>> our shindig extension code) and as such should be placed at a >>>> higher level? I guess that makes some sense to me, but on the >>>> other hand it seems like the tests themselves are all about >>>> testing the rave-portal web interface and the fact that they >>>> end up exercising some of our shindig extension code seems like >>>> an implementation detail that we might not need to represent in >>>> our SVN structure. >>>> >>>> I'm thinking that putting them under rave-portal/test might be >>>> another alternative: >>>> >>>> incubator/rave/trunk/rave-portal/src/test/selenium >>>> >>>> or maybe /test/webapp/selenium to be more consistent with the >>>> structure under the main tree (although I don’t think I like >>>> this as much): >>>> >>>> incubator/rave/trunk/rave-portal/src/test/webapp/selenium >>>> >>>> WDYT? >>>> >>>>> Regards, >>>>> >>>>> Ate >>> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 >>> (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using >>> GnuPG with Mozilla - http://enigmail.mozdev.org/ >>> >>> >> iQEcBAEBAgAGBQJOTRPzAAoJEEfVXEODPFID+DkH/iP3zcDNZ5E/FvFu/78CJML p >>> >> po9hPLyxQP00/2AMxOx+49I7Al1XxYfefVhu3xdXu78JrBijHTo/udXYkCPeCykb >>> >> Rvqktxw+daVR9E3HJeFch1CG0Ac8bMbqKgZcoQK3GZZJJKWkO7ILBL4WLLOB0i 1j >>> >> HGbaTFj1JRw7KPTvgY30ekpBWlm5x4JfSNhY11cVbVJvLtPgmdJc8yyrUhLSIGuY >>> >> qlmbKZzHNuv6V0jaGecvmTP2yoljX+OmPxIhmX0IPex23mm4yTXccvj1IYHzmSI Y >>> hFj4Rz8/lJP9IygO4G+gZEqMdW6tdtq4y1lNxeC1BLyA7EiVspaBdyNjZCb9an0= >>> =Bn8H -----END PGP SIGNATURE----- >> > -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOTUzsAAoJEEfVXEODPFIDqRQH/12EsLnkHLJ6kM/etD90982D xuhcXdA2DWvfxd4Wa6n+8GhniIjOirI70gxIStodiWJme/jAYMleyfmIWlbWDblo ajAB7tsRzTez1nfID5wsnlkTtzfOZF/gapHEmMjCsSsFDbgFGiFGTZknkvl35Qkm Y4WFUCR3e8p9wZup0J7ithbOf2hSDKmadcBUzzQSzSIGZCpwgt6J2vIvXhOF5ne/ cYDnBy4PgZ01ElgnQErMGY+Y43jrF6gEp4DyiC7CIlC8x14EpAhn+i5fsnpCIdpF ekdQh548cQDjN8OZb2lKfJOw7yM2TeoXsKWzdqbNTEXO5XDpv04NmeWz965FBPo= =uFtj -----END PGP SIGNATURE-----
