----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3449/#review4308 -----------------------------------------------------------
Thanks for the patch. See my remarks on the code. The most important thing is the missing unit test. trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserInfoController.java <https://reviews.apache.org/r/3449/#comment9707> Where is the test class for this controller? trunk/rave-portal-resources/src/main/resources/messages.properties <https://reviews.apache.org/r/3449/#comment9706> Dutch translations: Profiel van {0} Persoonsgegevens Voornaam: Achternaam: Algemene informatie Over mij: Burgerlijke staat: # if 'Status' means single, married etc Contact informatie E-mail: trunk/rave-portal-resources/src/main/resources/messages.properties <https://reviews.apache.org/r/3449/#comment9708> Status as in single/married? trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp <https://reviews.apache.org/r/3449/#comment9709> Please add link to Rave home, widget store and for admins the link to the admin interface - Jasha On 2012-01-10 21:23:49, Ankur Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3449/ > ----------------------------------------------------------- > > (Updated 2012-01-10 21:23:49) > > > Review request for rave and Marlon Pierce. > > > Summary > ------- > > Made a simple jsp page which displays the user profile. > Profile page has 3 tabs for the time being which on click will have a panel > slide down to show information. > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1229718 > trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/user_profile.jsp > PRE-CREATION > trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1229718 > trunk/rave-portal-resources/src/main/webapp/css/default.css 1229718 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp > PRE-CREATION > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp > 1229718 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_footer.jsp > PRE-CREATION > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java > 1229718 > trunk/rave-portal-resources/src/main/resources/messages.properties 1229718 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserInfoController.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3449/diff > > > Testing > ------- > > > Thanks, > > Ankur > >
