----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3449/#review4696 -----------------------------------------------------------
Ship it! i tried to address the comments and merged with latest trunk. There are certain look and feel issue need to be addressed as separate JIRA task - Raminder On 2012-01-24 20:04:12, Ankur Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3449/ > ----------------------------------------------------------- > > (Updated 2012-01-24 20:04:12) > > > Review request for rave and Marlon Pierce. > > > Summary > ------- > > This is just a skeleton of profile page > Addressed the issues mentioned and added the following:- > -> tabs and panels for user info display > -> horizontal list or menu to allow user to navigate to posts, about, search > friends and widgets pages > -> about jsp page allows user to view as well as edit the profile information > and save the same. > -> links on header tag to allow navigating to other pages as said > > Renamed user_profile.jsp to profile.jsp > Removed profile-body,profile-footer,profile-header,profile-menu and merged > them in profile.jsp > > > Diffs > ----- > > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java > PRE-CREATION > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java > 1235426 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java > 1235426 > > trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java > PRE-CREATION > trunk/rave-portal-resources/src/main/resources/messages.properties 1235426 > trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1235426 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp > 1235426 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp > 1235426 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_about.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_friend_finder.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_posts.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_widgets.jsp > PRE-CREATION > trunk/rave-portal-resources/src/main/webapp/css/default.css 1235426 > trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1235426 > trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js > PRE-CREATION > trunk/rave-portal-resources/src/test/javascript/raveProfileSpec.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/3449/diff > > > Testing > ------- > > > Thanks, > > Ankur > >
