----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3449/#review4358 -----------------------------------------------------------
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp <https://reviews.apache.org/r/3449/#comment9807> If you reuse the existing "templates.user.*" tiles definition this new file would not be needed. trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_footer.jsp <https://reviews.apache.org/r/3449/#comment9808> If you reuse the existing "templates.user.*" tiles definition this new file would not be needed. trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp <https://reviews.apache.org/r/3449/#comment9809> If you reuse the existing "templates.user.*" tiles definition this new file would not be needed. trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp <https://reviews.apache.org/r/3449/#comment9810> If you reuse the existing "templates.user.*" tiles definition this new file would not be needed. trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/user_profile.jsp <https://reviews.apache.org/r/3449/#comment9811> I would recommend naming this profile.jsp and just using the existing "templates.user.*" tiles definition to route requests to it. In that case you would need to embed the content you currently have in your profile_menu.jsp and profile_body.jsp files directly in this jsp. Those don't seem like pieces of content that you're likely to want to reuse elsewhere so I dont see embedding their content directly in this jsp as an issue. The profile_header.jsp and profile_footer.jsp files would then go away as the profile page would use the same header and footer as the rest of Rave. trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml <https://reviews.apache.org/r/3449/#comment9805> I don't see the need for a new tiles definition here specifically for the profile page -- it seems like the existing "templates.user.*" definition should work just fine. - Jesse On 2012-01-10 21:23:49, Ankur Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3449/ > ----------------------------------------------------------- > > (Updated 2012-01-10 21:23:49) > > > Review request for rave and Marlon Pierce. > > > Summary > ------- > > Made a simple jsp page which displays the user profile. > Profile page has 3 tabs for the time being which on click will have a panel > slide down to show information. > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1229718 > trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/user_profile.jsp > PRE-CREATION > trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1229718 > trunk/rave-portal-resources/src/main/webapp/css/default.css 1229718 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp > PRE-CREATION > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp > 1229718 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_footer.jsp > PRE-CREATION > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java > 1229718 > trunk/rave-portal-resources/src/main/resources/messages.properties 1229718 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserInfoController.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3449/diff > > > Testing > ------- > > > Thanks, > > Ankur > >
