----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100230/ -----------------------------------------------------------
(Updated 2011-01-06 19:51:26.681692) Review request for rekonq. Changes ------- highlighting the tabRect of a tab looked distracting and making the text blink was not possible using QGraphicsEffect, because tabRect returns a different rectangle if you use different styles. so i implemented the effect as a simple QObject that handles the highlighting on a QDynamicPropertyChangeEvent. Summary ------- This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window). I don't have a kde git account, so please merge it if you like it. Diffs (updated) ----- src/tabhighlighteffect.cpp PRE-CREATION src/CMakeLists.txt 6cf2651 src/mainview.cpp 94dc168 src/tabbar.h acd8e2f src/tabbar.cpp 286d7d4 src/tabhighlighteffect.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/100230/diff Testing ------- compiles and works Thanks, Johannes
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
