> On Jan. 14, 2011, 8:35 p.m., Benjamin Poulain wrote: > > src/tabbar.cpp, line 414 > > <http://git.reviewboard.kde.org/r/100230/diff/8/?file=6296#file6296line414> > > > > Shouldn't you set the deletion policy to > > QAbstractAnimation::DeleteWhenStopped to avoid leaking it?
this one is set when the animation starts - Johannes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100230/#review889 ----------------------------------------------------------- On Jan. 6, 2011, 8:06 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100230/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2011, 8:06 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > This patch highlights inactive tabs if their title has changed, so people get > aware of changes in the tabs (for instance a new message in a chat window). > > I don't have a kde git account, so please merge it if you like it. > > > Diffs > ----- > > src/CMakeLists.txt 6cf2651 > src/mainview.cpp 94dc168 > src/tabbar.h acd8e2f > src/tabbar.cpp 286d7d4 > src/tabhighlighteffect.h PRE-CREATION > src/tabhighlighteffect.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/100230/diff > > > Testing > ------- > > compiles and works > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
