David Turner <[EMAIL PROTECTED]> writes:
> Hello Owen,
>
> >
> > Actually this reading of the code is not correct ... Pango only
> > keeps alive a PangoXftFont/XftFont for
> >
> > - Any fonts currently referenced by the application
> > - The last MAX_FREED_FONTS (16) that are not otherwise referenced
> >
> > Now whether this is best way to do caching is another issue, but
> > it doesn't just keep arbitrary numbers of XftFont/FT_FACE objects
> > around.
> >
>
> Well, well, I've just done a grep on "XftFontClose" on the whole
> Pango sources, and it shows that this function is only called in
> _one_ place, line 465 of "pangoxft-fontmap.c".
>
> Unfortunately, this correspond to the case where the function
> "pango_xft_load_font_map_load_font" fails to properly set the
> character map on a new XftFont/FT_Face object..
>
> In other words, successfully opened XftFont objects seem to never
> be freed explicitely by Pango !! Is this a bug, or did I miss
> something ??
>
> (It seems you're correct for pangoft2-fontcache.c though..)
Well, I only was really claiming that Pango didn't keep
a reference to more than MAX_FREED_FONTS fonts, not that
they were actually freed ;-)
Indeed, the code to actually free fonts seems to have been
dropped along the way. Thanks for catching that.
Regards,
Owen
_______________________________________________
Render mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/render
