Fil: > Joonas Kylmälä wrote: >> I'm not talking about the method below the declarations, but instead >> about the code that is above the declarations: > > Yes, I understood. > I'd seen your point the first time.
Okay, it just made me doubt as you said "And that's what I did." for "Define fields either at the top of the file *or immediately before the methods that use them*." >> So it gives global i.e. public ipv6 address. > I think it was pretty clear from the context that I was referring to > IPv4. This shouldn't matter. I can test IPv4 in two weeks. > I'm still open to critics and suggestions, but while criticizing, please > keep in mind that I put actual work and time on what I did, and it's not > very pleasant to see people try to put my work down for the sake of it. I appreciate the work you have done and I'm not trying to make it any more less for just the sake of it. I'm doing code review so we can have easily maintainable and well working Replicant OS. Joonas _______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
