Hi, On Thu, 10 Oct 2019 00:35:05 +0300 Joonas Kylmälä <[email protected]> wrote:
> The phone number lookup service leaks private information so hide the > option to enable it. It may be a good idea to give a bit more context by explaining that it needs to be hidden because the "Disable phone number lookup settings during upgrade" only disable the settings when upgrading the database. > LookupSettingsFragment.class.getName(); > - target.add(lookupSettingsHeader); > + // target.add(lookupSettingsHeader); Here it would be better to instead remove completely the line, or if you want to leave something, add a text comment instead that explains what was removed and why. Note that I didn't have time to look into the broader context of that patch yet, so I don't know if lookupSettingsHeader should be completely removed or not. Denis.
pgpKJZltGYezH.pgp
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
