On Thu, 10 Oct 2019 22:08:17 +0300 Joonas Kylmälä <[email protected]> wrote:
> Hi, > > Joonas Kylmälä: > >> Note that I didn't have time to look into the broader context of > >> that patch yet, so I don't know if lookupSettingsHeader should be > >> completely removed or not. > > > > I will remove it completely in v2. Thanks for the review! > > oh actually, I had yesterday an idea with not removing all the > references to lookupSettingsHeader because usually that makes > maintaining the fork more difficult because the delta is bigger. So > then cherry-picks, merges, etc. will be more difficult. But I will > remove this one specific line instead of commenting it out in v2. > Sounds good? While the delta will be smaller, I'm not sure that it would have an impact that big on automatic rebases/cherry-picks. As for rebase/cherry-pick conflicts the commit message that might go in the v2, and the removal of all the block probably looks clear enough to most people that have written an application with a graphical toolkit (GTK, QT, EFL, etc). The issue here is that people may also need to copy/paste/modify this part of the code and/or read and/or modify other part of the code as well, so having something like that would confuse people unless there is a comment explaining the tradeoff nearby. And the comment explaining that would then add at least one more line anyway, so I find removing all the block more clean. Denis.
pgpSmnk1nhuhW.pgp
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
