Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
which do not have unit address.  Therefore usethe address space
of child device (actual DWC3 Controller) as the wrapper's address to
fix:

  exynos5422-odroidhc1.dtb: soc: usb3-0: {'compatible': 
['samsung,exynos5250-dwusb3'],
    ... } should not be valid under {'type': 'object'}

  exynos54xx.dtsi:145.21-159.5: Warning (simple_bus_reg): /soc/usb3-0: missing 
or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>

---

Changes since v1:
1. Use ranges with values and drop reg from usb-wrapper node.
2. Keep "usb" as wrapper's node name.
---
 arch/arm/boot/dts/exynos54xx.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/exynos54xx.dtsi 
b/arch/arm/boot/dts/exynos54xx.dtsi
index 3ec43761d8b9..5c799886c275 100644
--- a/arch/arm/boot/dts/exynos54xx.dtsi
+++ b/arch/arm/boot/dts/exynos54xx.dtsi
@@ -142,15 +142,15 @@ hsi2c_7: i2c@12cd0000 {
                        status = "disabled";
                };
 
-               usbdrd3_0: usb3-0 {
+               usbdrd3_0: usb@12000000 {
                        compatible = "samsung,exynos5250-dwusb3";
                        #address-cells = <1>;
                        #size-cells = <1>;
-                       ranges;
+                       ranges = <0x0 0x12000000 0x10000>;
 
-                       usbdrd_dwc3_0: usb@12000000 {
+                       usbdrd_dwc3_0: usb@0 {
                                compatible = "snps,dwc3";
-                               reg = <0x12000000 0x10000>;
+                               reg = <0x0 0x10000>;
                                interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
                                phys = <&usbdrd_phy0 0>, <&usbdrd_phy0 1>;
                                phy-names = "usb2-phy", "usb3-phy";
@@ -164,15 +164,15 @@ usbdrd_phy0: phy@12100000 {
                        #phy-cells = <1>;
                };
 
-               usbdrd3_1: usb3-1 {
+               usbdrd3_1: usb@12400000 {
                        compatible = "samsung,exynos5250-dwusb3";
                        #address-cells = <1>;
                        #size-cells = <1>;
-                       ranges;
+                       ranges = <0x0 0x12400000 0x10000>;
 
-                       usbdrd_dwc3_1: usb@12400000 {
+                       usbdrd_dwc3_1: usb@0 {
                                compatible = "snps,dwc3";
-                               reg = <0x12400000 0x10000>;
+                               reg = <0x0 0x10000>;
                                phys = <&usbdrd_phy1 0>, <&usbdrd_phy1 1>;
                                phy-names = "usb2-phy", "usb3-phy";
                                snps,dis_u3_susphy_quirk;
-- 
2.34.1

_______________________________________________
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant

Reply via email to