> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Saturday, January 28, 2023 2:57 AM
> To: Rob Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Alim Akhtar
> <[email protected]>; [email protected]; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]
> Cc: [email protected]; [email protected];
> ~postmarketos/[email protected]; Martin Jücker
> <[email protected]>; Henrik Grimler <[email protected]>; Sam
> Protsenko <[email protected]>; Chanho Park
> <[email protected]>; Marek Szyprowski
> <[email protected]>; Chanwoo Choi
> <[email protected]>; Krzysztof Kozlowski
> <[email protected]>
> Subject: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3
> node wrapper in Exynos7
> 
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address.  Therefore usethe address space of child
> device (actual DWC3 Controller) as the wrapper's address to
> fix:
> 
>   exynos7-espresso.dtb: soc@0: usb: {'compatible': ['samsung,exynos7-
> dwusb3'], ...
>     should not be valid under {'type': 'object'}
> 
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> 
> ---
Reviewed-by: Alim Akhtar <[email protected]>

Tested on exynos7-espresso and xHCI driver still gets probed, so 

Tested-by: Alim Akhtar <[email protected]>


> 
> Changes since v1:
> 1. New patch
> ---
>  arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index 82fee1b7caab..b1fa68835b09 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -690,7 +690,7 @@ usbdrd_phy: phy@15500000 {
>                       #phy-cells = <1>;
>               };
> 
> -             usbdrd: usb {
> +             usbdrd: usb@15400000 {
>                       compatible = "samsung,exynos7-dwusb3";
>                       clocks = <&clock_fsys0 ACLK_USBDRD300>,
>                              <&clock_fsys0 SCLK_USBDRD300_SUSPENDCLK>,
> @@ -699,11 +699,11 @@ usbdrd: usb {
>                               "usbdrd30_axius_clk";
>                       #address-cells = <1>;
>                       #size-cells = <1>;
> -                     ranges;
> +                     ranges = <0x0 0x15400000 0x10000>;
> 
> -                     usb@15400000 {
> +                     usb@0 {
>                               compatible = "snps,dwc3";
> -                             reg = <0x15400000 0x10000>;
> +                             reg = <0x0 0x10000>;
>                               interrupts = <GIC_SPI 223
> IRQ_TYPE_LEVEL_HIGH>;
>                               phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>;
>                               phy-names = "usb2-phy", "usb3-phy";
> --
> 2.34.1



_______________________________________________
Replicant mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/replicant

Reply via email to