"Roger A. Faulkner" wrote:
> > "Roger A. Faulkner" wrote:
> > > > Roland Mainz wrote:
> > > > > This is a sponsor request to "fix" ([1]) CR #6799167
> > > > > (http://bugs.opensolaris.org/view_bug.do?bug_id=6799167 - "real gcc
> > > > > build fails in libshell").
> > > > >
> > > > > [1]=The "fix" is more a workaround since I don't know exactly how the
> > > > > ctf*-tools can be fixed.
> > > > >
> > > > > My contributor ID is "OS0025".
> > > > >
> > > > > Webrev follows later when my "hg clone" is complete...
> > > >
> > > > Webrev is now available at
> > > > http://cr.opensolaris.org/~gisburn/ksh93_integration_cr_6799167_001/ -
> > > > can anyone give me a short code review for the change, please (we'll
> > > > file a new bug in bugster to make sure the original issues doesn't get
> > > > forgotten) ?
> > >
> > > The code change looks good to me (and compiles for me).
> > > (I've been concerned about the not-buildable-with-gcc
> > > issue for some time now. I thought I was the only one.)
> >
> > It was AFAIK the only one (there are other VLA users in the tree but
> > they all use the arithmetric expressions and therefore avoid this
> > xxx@@@!!!-trap).
> >
> > > Nit:
> > > Could you break the comment into more than one line,
> > > to make it fit in 80-columns, something like:
> > >
> > > /*
> > > * Allocate one extra array entry as workaround for:
> > > * CR 6799167 real gcc build fails in libshell
> > > */
> >
> > Fixed. I've uploaded the new webrev as
> > http://cr.opensolaris.org/~gisburn/ksh93_integration_cr_6799167_002/
>
> Beautiful. Thanks.
For the log:
I've filed CR #6811985 ('"ctfconvert" fails when gcc x86 executable uses
"VLA" (="Variable Length Array")') to get the bug in "ctfconvert" fixed
(see attached email, too).
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
-------------- next part --------------
An embedded message was scrubbed...
From: bugmail-sen...@sun.com
Subject: CR 6811985 Created, P2 opensolaris/triage-queue "ctfconvert" fails
when gcc x86 executable uses "VLA" (="Variable Length Array")
Date: Mon, 2 Mar 2009 11:51:47 -0700 (MST)
Size: 6017
URL:
<http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20090302/5490802d/attachment.nws>
