Hi Ceri, No problem. I agree that test case in the report is sufficient. I have one nit on the change.
Lines 336-344: For correctness, I would prefer that we replace any '.' with '_' after the last strlcat. On the other hand, we know the last strlcat wouldn't add any '.' into the string so I'm also ok with the current fix. Let me know you decide to do. I have a workspace built with the fix and plan to run a quick test before integration. Thanks, -tony Ceri Davies wrote: > Hi Tony, > > Apologies for the delay in replying, I've been away. > > Truth be told I've found it difficult to think of exciting test cases > for this one, so my testing has been pretty much just that in the bug > report. > > Ceri > > On Mon, Oct 08, 2007 at 10:37:58AM -0700, Tony Nguyen wrote: > >> Resend as I had the wrong email for Ceri. >> >> Tony Nguyen wrote: >> >>> Ceri, >>> Absolutely, I'd be happy to sponsor this request but still need to work >>> through registration to become an official sponsor. Will take a look at >>> the changes soon but can you list the testings you've done? >>> Thanks, >>> tony >>> >>>>> ----- Forwarded message from Ceri Davies <ceri at submonkey.net> ----- >>>>> >>>>> Date: Fri, 28 Sep 2007 22:01:28 +0100 >>>>> To: request-sponsor at opensolaris.org >>>>> From: Ceri Davies <ceri at submonkey.net> >>>>> Subject: [request-sponsor] Requesting sponsor for CR #6611124 >>>>> "inetconv may create manifests that svccfg cannot import" >>>>> >>>>> Hello, >>>>> >>>>> I would like to request a sponsor for the following bug: >>>>> >>>>> 6611124 inetconv may create manifests that svccfg cannot import >>>>> >>>>> A patch with my proposed and tested fix is available at: >>>>> http://shrike.submonkey.net/~ceri/os/6611124/ >>>>> >>>>> The patch is against the onnv-gate branch. >>>>> >>>>> My contributor agreement number is OS0135. >>>>> >>>>> Cheers, >>>>> >>>>> Ceri >>>>> >>>>> >>> _______________________________________________ >>> request-sponsor mailing list >>> request-sponsor at opensolaris.org >>> > >
