Comment #14 on issue 489 by thornsoft.chris: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489
I'm happy to see the comment blocking issue 963 being merged here. IMO, an ideal solution lets the reviewer block at the diff/comment level, and his/her overall "ship-it/sink-it" flag can't go to "ship-it" if they have unsatisfied "sink- it" blocks. The overall "ship-it" status for the review (across all reviewers) should be dependent on some rule, such as: "75% of participating reviewers designate "ship-it" and NO unresolved "sink-it" blocks". -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~----------~----~----~----~------~----~------~--~---
