Comment #23 on issue 489 by Jan.Koprowski: [ ] DON'T SHIP IT button

Basis of problem is in differences between OpenSource and commerical reviewing model. RB support OpenSource review model from nature. When I need update some informations in bug track I made this like this:
* When RB is submitted I update issue - review ok
* When RB comment is published I check Ship It and:
  * When checked I don't do anything
  * When unchecked I update issue - review rejected

Of course Ship It is stricly OpenSource function which doesn't have sens in commercial model but I think my idea is fine. But this should be noticed under webhooks implementation to pass enough informations to webhook in this situations.

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to