Comment #12 on issue 1668 by AaronJSherman: Diffs not applying cleanly circa 1.0.7 with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668

I believe that, yes, these are intentional in some cases. I also believe that they're unintentional in others. If post-review choked and said "I just can't handle these, mark them as binary or fix the line-endings" that would not be a great solution, but it would at least let users recover. Currently, the way it works, the review ends up with an error on the diffs page after it's been uploaded (and very often, after it's been published as users rarely check the diffs to see if they showed up correctly).
This leads to two problems:

1) Reviews that focus on the diff failure rather than the changes
2) User confusion because the error doesn't indicate what went wrong



--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to