Comment #12 on issue 2916 by Review Board does not respect line endings

Just verified that its not in 1.6.16 either, You would need to be on the 1.7 tree to have that change. The stripping of the newlines is what makes the difference.

With my patch on 1.7 tree, it would work because the strip takes care of removing the newlines before the regex parsing happens, but with 1.6.x, since the regex looks like for a line ending with "revision (XXXX)" it fails because windows styled line endings have a \r\n tacked after the "revision (XXXX)".

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to