------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4728/
------------------------------------------------------------------------------
New update by KG
For Beanbag, Inc. > RBTools > Ticket #4728
Reply:
I believe the real problem here is the fact that the remote is hardcoded to
`origin`. i.e. `_rev_list_youngest_remote_ancestor()` is always called with
`origin` as the third parameter.
This only works with git > 2.0 and when using a standard layout for svn.
Prior to git 2.0, `git-svn` did not use a standard prefix (see git svn man page
or https://git-scm.com/docs/git-svn#git-svn---prefixltprefixgt). Even with git
2.x, depending on the layout of the svn repository and how the clone was
created, a prefix of `origin` might not exist.
The order of `git rev-list SHA1_lastcommit_on_master --not
--remotes=origin` is a red herring. There is nothing wrong with the current
order. Reversing the order as @KG suggested can sometimes fix the problem, but
it only works for a different reason, not the way that the
`_rev_list_youngest_remote_ancestor()` function was intended.
The real fix would be to make the name of the remote configurable so that
it can work in non-standard situations. A better approach would be to
automatically detect the name of the remote svn prefix, but I don't think that
is trivial with git-svn. Although the documentation for
`_rev_list_youngest_remote_ancestor()` states that the `remote` parameter is
configurable, that is not true of the current implementation.
A workaround for those who have already checked out using `git-svn` 1.x and
do not have a standard prefix of `origin` is to manually change the
`ref/remotes/` prefix to `origin`.
The issue the @rfs613 mentioned about the `TypeError` is still a valid
issue, but it only affect python 3. I don't encounter this issue on python 2.7
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
