------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4728/
------------------------------------------------------------------------------
New update by KG
For Beanbag, Inc. > RBTools > Ticket #4728
Reply:
Looking at this a little more, I checked the code of the old version that
worked (0.7.11) and noticed that it was figuring out the name of the remote ref
for git-svn by parsing the output of `git svn rebase -n` (see here:
https://github.com/reviewboard/rbtools/blob/release-0.7.11/rbtools/clients/git.py#L267).
I think that would be be the best way to do this instead of hardcoding
`origin`.
Also note that the `--remotes=` argument to `git rev-list` will not work in
all cases. Since `git rev-parse` automatically turns the argument into a
wildcard prefix match by appending `/*` to the argument of `--remotes=`, it
will only work of the argument given contains directories or branches beneath
it. In some case, the remote is a single ref file which will cause it to not
act as intended. Note that if the ref given for `--remotes=prefix` does not
exist `git` will not issue an error, it will just ignore that parameter. I
think the proper way to do this for `git-svn` would be to determine the
upstream ref like 0.7.11 did, and just use that as a `--not SHA1` argument
instead of the `--remotes=` to cover all cases.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
