That bare except sucks. We definitely need to do something about it, we just haven't yet. I thought at one point we actually relayed the error back to the web UI, but I don't recall for sure.
Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 9, 2008 at 12:25 PM, Chris Clark <[EMAIL PROTECTED]> wrote: > > On 10/9/2008 12:12 PM, Paulo Eduardo Neves wrote: > > .... > > Here it is, the Abominable Except Catch All code smell. I can't count > > how many times this beast hurt me. The exception is eaten and nothing > > happens in the interface. I've put a raise after the pass and got > > this: > > ..... > > Should I open an issue for this? I didn't dig inside the code to see > > it, maybe it is just a reguar expression. > > > > Excellent sleuthing! > > I would log a bug for at least the bare except as you can't see the > error other wise. I did a quick check for "except:" and there are a few: > > admin\cache_stats.py: except: > admin\checks.py: except: > admin\management\evolutions.py: except: > admin\siteconfig.py: except: > django_evolution\evolve.py: except: > djblets\auth\forms.py: except: > djblets\auth\util.py: except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py:except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\feedview\feedparser.py: except: > djblets\siteconfig\context_processors.py: except: > djblets\util\misc.py: except: > djblets\util\misc.py: except: > reviews\models.py: except: > reviews\views.py: except: > webapi\json.py: except: > webapi\json.py: except: > webapi\json.py: except: > webapi\json.py: except: > > > Certainly worth logging another bug that the diff parser code isn't > localized - the worse that can happen is that the bug gets marked won't > fix. > > Chris > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
