Just in this solution : - configuration are inside python files, - custom hack are made to display a different url for user instead of url used by reviewboard - python script are not in the same repo as reviewboard, this is another dependice..
Regards, Mathieu On 18 nov, 16:32, cristian607 <[EMAIL PROTECTED]> wrote: > Hello, > > Thank you for sharing this information. We are starting to use review > board, and I find the mechanism you described very interesting. I will > try to make it work on our windows installation of review board. > > I have a question though. Why do you say "I known it's not a perfect > solution, but maybe the actual code can help somebody :) ". What are > the drawbacks that you see in this method? I dont see any. > > Best regards, > CS. > > On Nov 12, 12:27 pm, "tito -" <[EMAIL PROTECTED]> wrote: > > > Hi everyone, > > > At my company (netasq.com), we've work to use reviewboard with > > pre-commit hook in subversion. > > A developper can now post a review instead of real commiting his > > changes. Example: > > > ------------------------------------------------------------------------------- > > 10:40:38 [EMAIL PROTECTED] reviewboard $ svn commit -m 'test review > > (draftreview)' README > > Envoi README > > Transmission des données .svn: Échec de la propagation (commit), détails : > > svn: Commit blocked by pre-commit hook (exit code 1) with output: > > Review request #34 posted. > > > https://************/reviewboard/r/34 > > ------------------------------------------------------------------------------- > > > Installation: > > > 1/ To make it work, you need to copy > > * postreview.py (a modified version of contrib/tools/post-review.py, > > to make it work with custom diff) > > * pre-commit-hook-reviewboard.py > > in your hooks subversion directory, and make them executable. > > > 2/ Open and edit configuration in pre-commit-hook-reviewboard.py > > > 3/ Copy/paste content in your pre-commit subversion hook : > > # Reviewbord pre-commit > > REVIEWBOARD_HOOK=`dirname $0`/pre-commit-hook-reviewboard.py > > $REVIEWBOARD_HOOK "$REPOS" "$TXN">> /tmp/reviewboard_commit.log > > RET=$? > > # 0 => no review > > # <0 => error > > # 1 => review posted > > if [ $RET -lt 0 ]; then > > echo >&2 > > echo "Review asked, but we got an error." >&2 > > echo "Please report this error to administrator, thanks !" >&2 > > echo >&2 > > exit 1 > > fi > > > if [ $RET -eq 1 ]; then > > exit 1 > > fi > > > I known it's not a perfect solution, but maybe the actual code can > > help somebody :) > > > Regards, > > > Mathieu > > > postreview.py > > 31KViewDownload > > > pre-commit-hook-reviewboard.py > > 8KViewDownload --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
