We probably want to use os.path.pathsep instead of os.environ.get('IFS')
anyway.Btw, I get a bounceback every time I e-mail you. Not sure if you're seeing any of my responses. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 5:04 AM, Alexey Morozov <morozov...@ngs.ru> wrote: > > Hi! > > I just discovered that git client in ReviewBoard isn't usable in my > installation (an usual Apache/FastCGI/Django-1.0.2/RB-1.0postRC1). The > problem is in this code fragment in reviewboard/scmtools/git.py: > > for dir in os.environ['PATH'].split(os.environ.get('IFS', ':')): > if os.path.exists(os.path.join(dir, 'git')): > found = True > break > if not found: > # This is technically not the right kind of error, but it's the > # pattern we use with all the other tools. > raise ImportError > > In my setup (I didn't do anything special, I swear! :) ) os.environ > contains > only these values (dumped from the point immediately preceding the check): > > environ={'TZ': 'Asia/Dhaka', 'PYTHON_EGG_CACHE': > '/var/www/webapps/reviewboard/tmp/egg_cache', 'DJANGO_SETTINGS_MODULE': > 'reviewboard.settings'} > > Despite such a crippled environment settings git runs just fine > (from /usr/bin/), so I guess it's some Django/FastCGI "security measures". > > I'm going to remove the check above or at least make it actually check git > existance. > > Alexey Morozov > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
