For most folks, as long as the address that Review Board is using is the canonical FQDN (cname, I think it's called) for the Perforce server, everything should work.
However, there are some situations that are currently broken. We have a couple perforce servers that have different canonical names depending on which network you are on, and there's currently no sane way to make post-review work from all networks since you have to pick one name. This problem has bit us a couple times and I filed Issue 967 (http://code.google.com/p/reviewboard/issues/detail?id=967) on this a month or so ago. As I said in the bug, I'd really rather RB/post-review use the raw Server address: from p4 info as the server's identifier because I think it will always be the same everywhere. If for whatever reason that address isn't reachable from wherever the RB server is, the server alias field should let you pick a different name to reach it. That said, this shouldn't generally cause a problem with proxy servers. post-review uses the canonical FQDN to identify the Perforce server to the Review Board server, but it just issues raw p4 commands for all the Perforce operations. So if your p4 environment is configured to use a p4proxy, all the actual p4 operations will go to the proxy. -- Paul ________________________________________ From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On Behalf Of Tom Sakkos [nasis...@gmail.com] Sent: Tuesday, May 05, 2009 1:32 PM To: reviewboard@googlegroups.com Subject: Re: Review Bord and Perforce integration problem This is an issue we've run into as well. While I may be incorrect in my assumption here, since I haven't gotten around to digging deeper, ReviewBoard compares the server connection's FQDN to the domain name you specified in the administration settings. Two issues: 1) If you try to provide an alias domain name, it fails. 2) If you try to use a perforce proxy server it will fail because ReviewBoard tries to reach the original perforce server. This can be an issue, especially when post-review grabs diffs using the original perforce server which is across the Atlantic :-(. While not a showstopper, it's merely an inconvenience. The simple solution is to grab: {'repository_path': 'perforce.oberonmedia.local:1666', 'changenum': '73292'} and add "perforce.oberonmedia.local:1666" as one of the servers in administration. -Tom On Tue, May 5, 2009 at 3:09 PM, Christian Hammond <chip...@chipx86.com<mailto:chip...@chipx86.com>> wrote: You're using a repository that Review Board doesn't know. You'll have to make sure the Review Board server has an entry for (and can reach) perforce.oberonmedia.local:1666. Christian -- Christian Hammond - chip...@chipx86.com<mailto:chip...@chipx86.com> Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 6:06 AM, Avivale <aviv...@gmail.com<mailto:aviv...@gmail.com>> wrote: I am trying to create Review Request for an existing change list and get the following error: >post-review.py -d 73292 >>> p4 info >>> repository info: Path: perforce.oberonmedia.local:1666, Base path: None, >>> Supports changesets: True >>> Generating diff for changenum 73292 >>> p4 describe -s 73292 >>> Processing edit of //depot/Aviva/Branch2/Doc2.txt >>> Writing "//depot/Aviva/Branch2/Doc2.txt#2" to >>> "c:\docume~1\admini~1\locals~1\temp\1\tmpixyye8" >>> p4 print -q //depot/Aviva/Branch2/Doc2.txt#2 >>> p4 where //depot/Aviva/Branch2/Doc2.txt >>> diff -urNp c:\docume~1\admini~1\locals~1\temp\1\tmpixyye8 >>> C:/WS/Aviva.Levin_ReviewBoard\depot\Aviva\Branch2\Doc2.txt >>> Looking for 'review.example.com<http://review.example.com> /' cookie in >>> C:\Documents and Settings\Administrator\Local Settings\Application >>> Data\.post-review-cookies.txt >>> Loaded valid cookie -- no login required >>> Attempting to create review request for 73292 >>> HTTP POSTing to http://review.example.com/api/json/reviewrequests/new/: >>> {'repository_path': 'perforce.oberonmedia.local:1666', 'changenum': '73292'} Error creating review request: The repository path specified is not in the list of known repositories (code 206) System setteings are : P4PORT=perforce:1666 P4CLIENT=Aviva.Levin_ReviewBoard P4USER=Aviva.Levin OS is WIN. Have anyone some suggestion for resolution of this issue? Tx, Aviva --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
