On Thu, May 7, 2009 at 10:08 AM, Tom Emerson <tremer...@gmail.com> wrote: [...] > Why is svn diff being invoked with --diff-cmd? I can't force the rest > of the company to install 'diff', and certainly when they manually > upload the diffs they are not using --diff-cmd to generate them, so > why is post-review?
Well, I found an answer to this in the Review Board bug list: http://code.google.com/p/reviewboard/issues/detail?id=769#c1 Specifically, 'svn diff doesn't give us a usable diff if there are moved or copied files. We can probably look for "diff" in the path and show a useful error message, though.' This is unfortunate... the requirement of an external diff tool slightly complicates things for us. -tree -- Tom Emerson tremer...@gmail.com http://treerex.blogspot.com/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
