Hi Tom, You can try removing the --diff-cmd flags. I agree that it's not ideal, and I'd like to do something better, but it hasn't been as high on the priority list and some other things. What I'd really like to do down the road is to have us take care of providing a working diff tool for use in post-review (written in Python) so that we don't require diff at all, but that's going to require a lot of testing.
What we do at VMware is that we have a central bin directory that everyone has in their path, and we hvae a copy of post-review and diff there. Works pretty well for us. Christian -- Christian Hammond - [email protected] Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, May 7, 2009 at 7:54 AM, Tom Emerson <[email protected]> wrote: > > On Thu, May 7, 2009 at 10:08 AM, Tom Emerson <[email protected]> wrote: > [...] > > Why is svn diff being invoked with --diff-cmd? I can't force the rest > > of the company to install 'diff', and certainly when they manually > > upload the diffs they are not using --diff-cmd to generate them, so > > why is post-review? > > Well, I found an answer to this in the Review Board bug list: > > http://code.google.com/p/reviewboard/issues/detail?id=769#c1 > > Specifically, > > 'svn diff doesn't give us a usable diff if there are moved or copied > files. We can > probably look for "diff" in the path and show a useful error message, > though.' > > This is unfortunate... the requirement of an external diff tool > slightly complicates things for us. > > -tree > > -- > Tom Emerson > [email protected] > http://treerex.blogspot.com/ > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
