Hi,

We're using Python's URL building functions for building that path. I
don't know why it was built that way. We should probably do some
validation for that (care to file a bug?)

As for the config file, .reviewboardrc is actually a Python file, so
it must use Python syntax. That means in this case that it needs
quotes around the URL.

Christian

On Saturday, June 12, 2010, Joachim Worringen <[email protected]> wrote:
> On 3 Jun., 10:48, Christian Hammond <[email protected]> wrote:
>> The value passed to --server must be a full URL, not just a file path.
>
> Thanks, Christian, using --server=http://testsrv/reviews actually
> helped.
>
> But I still wonder why the incomplete URL "testsrv/reviews" is then
> expanded to http://testsrv/reviews/testsrv/reviews/ - it seems
> http://testsrv/reviews is prepended, but where does it get this URL
> from?
>
> Also, where is the problem with the rc-file shown below (from my
> original posting):
>
> [joac...@testsrv perf]$ cat ~/.reviewboardrc
> REVIEWBOARD_URL=http://testsrv/reviews
> [joac...@testsrv perf]$ post-review  -d
> Syntax error in config file: /home/joachim/.reviewboardrc
> Line 1 offset 21
>
> [...]
>> > [joac...@testsrv perf]$ post-review  -d --server=testsrv/reviews
> [...]
>> > >>> Logging in with username "joachim"
>> > >>> HTTP POSTing to
>> >http://testsrv/reviews/testsrv/reviews/api/json/accounts/login/:
>> > {'username': 'joachim', 'password': '**************'}
>>
>> > >>> Got HTTP error: 404: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0
>> > Transitional//EN"
>>
>> > Obviously, the URL is incorrect: the server string "testsrv/reviews"
>> > is repeated.
>
> --
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to 
> [email protected]
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en

-- 
-- 
Christian Hammond - [email protected]
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to