Thanks Christian, I will disable syntax highlighting and will watch the performance and let you know the status.
Thanks, Mohan. On Mon, Oct 18, 2010 at 12:26 AM, Christian Hammond <[email protected]>wrote: > Please disable syntax highlighting (Admin UI -> Settings -> Diff viewer) > and see if that helps. > > Apache *will* use a lot of CPU when generating a side-by-side diff for a > large file. There's a lot of processing that must take place for generating > a diff. It's just an unavoidable thing. But it shouldn't be causing massive > performance problems. Provided things are cached, it should get better. > > We know of Review Board being used at many companies, VMware included, with > thousands of users and frequent review request creation/diff updates. The > spike in CPU usage hasn't caused a problem. > > Is it that performance is really terrible, or just that you're seeing > spikes if you watch the processes? > > > Christian > > -- > Christian Hammond - [email protected] > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Sun, Oct 17, 2010 at 8:45 AM, bugfree <[email protected]> wrote: > >> nah. not centos. I'm testing on a gentoo too and see similar issues. >> >> restart apache: >> ps -eo pmem,pcpu,rss,vsize,args returns >> >> 1.1 0.0 23588 39108 /usr/sbin/apache2 -D DEFAULT_VHOST ... >> >> for every apache process. >> >> If I open a diff for a file ~5Mb file one apache process jumps to >> >> 16.0 0.0 332192 353328 /usr/sbin/apache2 -D DEFAULT_VHOST ... >> >> while the others stays the same. >> >> I go back to the dashboard and reopen the very same diff I end up >> with >> >> 16.0 0.0 332192 353328 /usr/sbin/apache2 -D DEFAULT_VHOST ... >> 16.0 0.0 331640 352876 /usr/sbin/apache2 -D DEFAULT_VHOST ... >> %MEM %CPU RSS VSZ COMMAND >> 1.8 0.0 38740 119912 /usr/bin/memcached -d -p 11211 -U 11211 -l >> 127.0.0.1 -m 512 -c 1024 -u memcached -P /var/run/memcached/ >> memcached-11211.pid -r -I 4 >> 1.1 0.0 23588 39108 /usr/sbin/apache2 -D DEFAULT_VHOST ... >> .... >> >> and so on. on the third view of the same diff a third process grows. >> will test mod_wsgi and let you know. >> thanks >> >> >> On Oct 15, 9:34 pm, Jan Koprowski <[email protected]> wrote: >> > It looks like the issue is CentOS. >> > >> > 1) Try to switch from mod_python to mod_wsgi (or vice versa) >> > 2) Turn of memcache check is issue gone (switch to file cache) >> > >> > I belive this is good reason to send ticket to CentOS team. >> > >> > >> > >> > On Fri, Oct 15, 2010 at 4:01 PM, bugfree <[email protected]> wrote: >> > > Same issue here. >> > > I'm on centos with RB 1.5. >> > > My source files can be as big as 20Mb which I didn't really expect to >> > > be an issue. turns out viewDiff can take several minutes. >> > >> > > but performance aside I think I'm looking at some memory leakage. >> > >> > > after running it for a few days while no user is connected running >> > >> > > ps -eo pmem,pcpu,rss,vsize,args | sort -k 1 -r | less >> > >> > > is giving me >> > > -------------------------------- >> > > 16.5 0.0 343748 370000 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > > 16.0 0.0 331968 362408 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > > 15.8 0.0 327960 355388 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > > 15.4 0.0 321124 371132 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > > 10.4 0.0 216932 363664 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > > 6.4 0.0 134208 372964 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > > 4.1 0.0 85308 203736 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > > 1.8 0.0 38676 119912 /usr/bin/memcached -d -p 11211 -U 11211 -l >> > > 127.0.0.1 -m 512 -c 1024 -u memcached -P /var/run/memcached/ >> > > memcached-11211.pid -r -I 4 >> > > 0.8 0.0 18592 50876 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > > 0.7 0.0 15656 362552 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > > 0.1 0.0 3884 242392 /usr/sbin/mysqld --defaults-file=/etc/mysql/ >> > > my.cnf --basedir=/usr --datadir=/export/mysql --pid-file=/var/run/ >> > > mysqld/mysqld.pid --socket=/var/run/mysqld/mysqld.sock >> > > 0.0 0.0 1196 5484 /usr/sbin/vmtoolsd >> > > 0.0 0.0 1136 7360 sshd: r...@pts/1 >> > > 0.0 0.0 944 3004 -bash >> > > -------------------------------- >> > >> > > restarting apache the top memory usage goes back to being memcahed >> > > while apache moves to 2nd place with >> > > 0.2 1.2 5680 11780 /usr/sbin/apache2 -D DEFAULT_VHOST -D INFO -D >> > > SSL -D SSL_DEFAULT_VHOST -D LANGUAGE -D PYTHON -d /usr/lib/apache2 -f >> / >> > > etc/apache2/httpd.conf -k start >> > >> > > I'm going to configure apache so that each process is restarted after >> > > just a few requests as a short term workaround. >> > >> > > can anyone help me out identify where the issue is? >> > >> > > TIA >> > >> > > On Oct 15, 9:48 am, mohan kumar <[email protected]> wrote: >> > >> Oh ok. >> > >> > >> On Fri, Oct 15, 2010 at 1:08 PM, Thilo-Alexander Ginkel < >> [email protected]>wrote: >> > >> > >> > On Fri, Oct 15, 2010 at 09:22, Mohan <[email protected]> wrote: >> > >> > > Only RB is running on the server. >> > >> > >> > > when i did 'ps' it shows the following apache instances. >> > >> > >> > > [r...@rboard log]# ps -ef | grep httpd >> > >> > > apache 1279 22272 0 01:51 ? 00:00:03 /usr/sbin/httpd >> > >> > > apache 12843 22272 0 07:29 ? 00:00:00 /usr/sbin/httpd >> > >> > > [...] >> > >> > > apache 22453 22272 0 Oct14 ? 00:00:04 /usr/sbin/httpd >> > >> > >> > > just thinking on Prefork model. >> > >> > >> > You're already running prefork... >> > >> > >> > Regards, >> > >> > Thilo >> > >> > >> > -- >> > >> > Want to help the Review Board project? Donate today at >> > >> >http://www.reviewboard.org/donate/ >> > >> > Happy user? Let us know athttp://www.reviewboard.org/users/ >> > >> > -~----------~----~----~----~------~----~------~--~--- >> > >> > To unsubscribe from this group, send email to >> > >> > [email protected]<reviewboard%[email protected]> >> <reviewboard%[email protected]<reviewboard%[email protected]> >> > >> > >> > For more options, visit this group at >> > >> >http://groups.google.com/group/reviewboard?hl=en >> > >> > > -- >> > > Want to help the Review Board project? Donate today athttp:// >> www.reviewboard.org/donate/ >> > > Happy user? Let us know athttp://www.reviewboard.org/users/ >> > > -~----------~----~----~----~------~----~------~--~--- >> > > To unsubscribe from this group, send email to >> [email protected]<reviewboard%[email protected]> >> > > For more options, visit this group athttp:// >> groups.google.com/group/reviewboard?hl=en >> > >> > -- >> > >> > ><> Jan Koprowski >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> [email protected]<reviewboard%[email protected]> >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > [email protected]<reviewboard%[email protected]> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
