Hi Christian, We have been using Perfoce as the source control tool; review board for the code review but review board throws error when developers post the binary files.
We got this kind of error: This tool looks at the given Pending-CL# & posts it for review. [ Version: 20100217_1023/0.8] Arguments: --p4vgui,--p4-client,user_Citrix_CDBnew,--p4-cl,358296,-d post-review config: C:\<path> \Local Settings\Application Data \.reviewboardrc post-review cookie: C:\<path> \Application Data\.post-review- cookies.txt >>> "C:/Program Files/WinExePostReview/diff.exe" –urNp temp.spd Traceback (most recent call last): File "post-review.py", line 2674, in <module> File "post-review.py", line 2638, in main File "post-review.py", line 1403, in diff File "post-review.py", line 1654, in _changenum_diff File "post-review.py", line 1737, in _do_diff IndexError: list index out of range Could you please help on this issue? Thanks, Mohak Patel On May 16, 2:10 pm, Christian Hammond <chip...@chipx86.com> wrote: > You shouldn't be getting an error. If the SCM is configured correctly, with > the file type being set to binary, then the diff should just basically say > "This is a binary file." The problem of course is that you can't actually > review that file, but we're adding support for actual reviewable file > attachments in 1.6, so that might help in some cases. > > What type of file is this? And what type of repository? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > > > > > On Mon, May 16, 2011 at 2:07 PM, Kunjal <kunjal.par...@gmail.com> wrote: > > Hello, > > > We have RB-GIT integration and there are many times when the developer > > adds binary files with the review. > > When user tries to post review with binary file, we get error and > > review can not be posted. > > What is the best way to overcome this problem? > > > Thanks > > Kunjal > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~----------~----~----~----~------~----~------~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
