Hi Dennis, I've looked at the earlier post you mentioned, and in its answer there was a link to a nice guide of using post-review in combination with Perforce:
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#posting-paths I recommend reading it, I think it is detailed at the right level. As you can see, there is no mention of --revision-range option of course. But if you want to review exactly one changelist, use the simple changenum syntax. Maybe I misunderstand your problem, in this case specify it a bit deeper... Hope this helped: Gyula On Tue, Dec 27, 2011 at 7:31 AM, DXM <dxm...@gmail.com> wrote: > Hi Gyula, > > Thank you for the reply. I'm definitely interested in the syntax. We > already rolled out the RB in our team, so this wasn't just an > exercise :). > > Looking forward to hearing back from you in January > > -- Dennis > > > On Dec 23, 4:15 pm, Gyula Faller <faller.gy...@gmail.com> wrote: > > Hi, > > > > You can send a revision range in case of Perforce too, but with a > > different syntax. You can specifiy a list of file ranges. I on holyday > now, > > and I don't remember the exact form but something like > > > > post-review > > perforce-file-path1#file-start-revid,perforce-file-path1#file-stop-revid > > perforce-file-path2#file-start-revid,perforce-file-path2#file-stop-revid > > > > or you can use @chgnum instead of #revid as well. > > > > If you are interested in the exact syntax I can show you in January. > > > > Gyula > > > > > > > > > > > > > > > > On Thu, Dec 22, 2011 at 9:47 PM, DXM <dxm...@gmail.com> wrote: > > > I know this question has been asked before (e.g. one of many: > > > > >http://groups.google.com/group/reviewboard/browse_thread/thread/41861. > .. > > > ), > > > but it's still not clear if this functionality is actually supported. > > > > > I've read and reread the manual, specifically the paragraph on > > > reviewing committed code and more specifically on explanation of this > > > command: "$ post-review --revision-range=STARTREV:STOPREV" > > > > > I'm using Perforce. Does RB support this with Perforce? If it does, > > > what is "STARTREV" and "STOPREV"? are these file revisions or > > > changelist( aka changeset) numbers? If they are changelist numbers, > > > is it going to include everyone else's changelists as well? We have > > > about 200 people checking in code. By the time I get around to > > > responding to a code review feedback, there can be a lot of other > > > changelists between original and the new one. How does this work in > > > that scenario? Is it possible to just provide a discrete list of > > > changelists that I want to have included in a review? > > > > > -- > > > Want to help the Review Board project? Donate today at > > >http://www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~----------~----~----~----~------~----~------~--~--- > > > To unsubscribe from this group, send email to > > > reviewboard+unsubscr...@googlegroups.com > > > For more options, visit this group at > > >http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
