Hey Alfred,

This is a database configuration issue. I don't know the key off-hand, but
you can increase the max packet size in MySQL.

That said, we do have a 1MB limit for diffs now (but that's not what you're
hitting), as Review Board can get bogged down if too many people are
processing large diffs at once. It's not configurable yet, but in general,
very large diffs can and should generally be avoided. They're quite hard to
review, and usually mean that there's some auto-generated code or something
in them that could be split out for the sake of review purposes.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, May 7, 2012 at 12:08 PM, Alfred von Campe <alf...@von-campe.com>wrote:

> I recently upgraded our ReviewBoard server to version 1.6.6.  First,
> thanks for a great product and an easy upgrade; the upgrade instructions
> worked flawlessly.  The issue described below may have nothing to do with
> the upgrade, but I thought I'd mention it just in case.
>
> Today a user complained to me that he can't create a new review via the
> web interface and a patch file (i.e., not using post-review).  Here is the
> error log the server automatically generated (slightly redacted):
>
> Traceback (most recent call last):
>
>  File
> "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/core/handlers/base.py",
> line 111, in get_response response = callback(request, *callback_args,
> **callback_kwargs)
>  File
> "/usr/lib/python2.4/site-packages/Djblets-0.6.16-py2.4.egg/djblets/auth/util.py",
> line 46, in _checklogin return view_func(request, *args, **kwargs)
>  File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.6-py2.4.egg/reviewboard/reviews/views.py",
> line 253, in new_review_request local_site=local_site)
>  File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.6-py2.4.egg/reviewboard/reviews/forms.py",
> line 234, in create attach_to_history=True)
>  File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.6-py2.4.egg/reviewboard/reviews/forms.py",
> line 286, in create history)
>  File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.6-py2.4.egg/reviewboard/diffviewer/forms.py",
> line 142, in create filediff.save()
>  File
> "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/db/models/base.py",
> line 460, in save self.save_base(using=using, force_insert=force_insert,
> force_update=force_update)
>  File
> "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/db/models/base.py",
> line 553, in save_base result = manager._insert(values,
> return_id=update_pk, using=using)
>  File
> "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/db/models/manager.py",
> line 195, in _insert return insert_query(self.model, values, **kwargs)
>  File
> "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/db/models/query.py",
> line 1436, in insert_query return
> query.get_compiler(using=using).execute_sql(return_id)
>  File
> "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/db/models/sql/compiler.py",
> line 791, in execute_sql cursor = super(SQLInsertCompiler,
> self).execute_sql(None)
>  File
> "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/db/models/sql/compiler.py",
> line 735, in execute_sql cursor.execute(sql, params)
>  File
> "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/db/backends/mysql/base.py",
> line 86, in execute return self.cursor.execute(query, args)
>  File
> "/usr/lib/python2.4/site-packages/MySQL_python-1.2.2-py2.4-linux-i686.egg/MySQLdb/cursors.py",
> line 166, in execute
>  File
> "/usr/lib/python2.4/site-packages/MySQL_python-1.2.2-py2.4-linux-i686.egg/MySQLdb/connections.py",
> line 35, in defaulterrorhandler
>
> OperationalError: (1153, "Got a packet bigger than 'max_allowed_packet'
> bytes")
>
>
> <ModPythonRequest
> path:/rb/r/new/,
> GET:<QueryDict: {}>,
> POST:<QueryDict: {u'parent_diff_path': [u''], u'changenum': [u''],
> u'basedir': [u'branches/XXXXXX'], u'repository': [u'15']}>,
> COOKIES:{'rbsessionid': 'f526a10b383c17b8e9b62dd8324badc4'},
> META:{'AUTH_TYPE': None,
>  'CONTENT_LENGTH': '1035928',
>  'CONTENT_TYPE': 'multipart/form-data; boundary=----
> WebKitFormBoundaryrbuBf2aclFoD5s3R',
>  'GATEWAY_INTERFACE': 'CGI/1.1',
>  'HTTP_ACCEPT':
> 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
>  'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
>  'HTTP_ACCEPT_ENCODING': 'gzip,deflate,sdch',
>  'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8',
>  'HTTP_CACHE_CONTROL': 'max-age=0',
>  'HTTP_CONNECTION': 'keep-alive',
>  'HTTP_CONTENT_LENGTH': '1035928',
>  'HTTP_CONTENT_TYPE': 'multipart/form-data; boundary=----
> WebKitFormBoundaryrbuBf2aclFoD5s3R',
>  'HTTP_COOKIE': 'rbsessionid=f526a10b383c17b8e9b62dd8324badc4',
>  'HTTP_HOST': 'hepdswsrv.XXXXX.com',
>  'HTTP_ORIGIN': 'http://hepdswsrv.XXXXX.com',
>  'HTTP_REFERER': 'http://hepdswsrv.XXXXX.com/rb/r/new/',
>  'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows NT 6.1; WOW64)
> AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.168 Safari/535.19',
>  'PATH_INFO': u'/rb/r/new/',
>  'PATH_TRANSLATED': None,
>  'QUERY_STRING': None,
>  'REMOTE_ADDR': '10.66.42.66',
>  'REMOTE_HOST': None,
>  'REMOTE_IDENT': None,
>  'REMOTE_USER': None,
>  'REQUEST_METHOD': 'POST',
>  'SCRIPT_NAME': '',
>  'SERVER_NAME': 'hepdswsrv.XXXXX.com',
>  'SERVER_PORT': 80,
>  'SERVER_PROTOCOL': 'HTTP/1.1',
>  'SERVER_SOFTWARE': 'mod_python'}>
>
>
> The patch file is right around 1MB. What is the limit and is there a way
> to increase it if this is indeed the issue?
>
> Alfred
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to