SetEnv HTTPS on
In the apache config worked like a charm though.

I did end up filing this issue
http://code.google.com/p/reviewboard/issues/detail?id=2639
I'm not sure yet if this will cause problems now that I've solved the
redirect https issues.

On Sat, Jun 16, 2012 at 11:56 PM, Dan Dumont <ddum...@gmail.com> wrote:

> I found
> https://groups.google.com/forum/?fromgroups#!topic/reviewboard/yIOamU1uvIY
>
> But I tried setting
>
>> os.environ['HTTPS'] = "on"
>
>
> In the reviewboard.wsgi file, but no dice.  I'm pretty sure we have a
> reverse proxy of some sort in front of us terminating SSL at the the border.
> Would be nice if you guys could just return protocol relative urls  //
> reviewboard.apache.org/etc...
>
> Any advice on where to stick that config setting to force https urls?
>
> On Saturday, June 16, 2012 11:16:27 PM UTC-4, Dan Dumont wrote:
>>
>> Request URL:
>> https://reviews.apache.org/**api/review-requests/5345/?api_**format=json<https://reviews.apache.org/api/review-requests/5345/?api_format=json>
>>
>> responds:
>>
>>
>>    1. review_request: {status:**pending, last_updated:2012-06-17
>>    02:58:20, description:,…}
>>       1. branch: ""
>>       2. bugs_closed: []
>>       3. changenum: null
>>       4. description: ""
>>       5. id: 5345
>>       6. last_updated: "2012-06-17 02:58:20"
>>       7. links: {diffs:{href:http://**reviews.apache.org/api/review-**
>>       
>> requests/5345/diffs/<http://reviews.apache.org/api/review-requests/5345/diffs/>,
>>       method:GET},…}
>>          1. changes: {href:http://reviews.**apache.org/api/review-**
>>          
>> requests/5345/changes/<http://reviews.apache.org/api/review-requests/5345/changes/>,
>>          method:GET}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/**changes/<http://reviews.apache.org/api/review-requests/5345/changes/>
>>             "
>>             2. method: "GET"
>>          2. delete: {href:http://reviews.**apache.org/api/review-**
>>          requests/5345/<http://reviews.apache.org/api/review-requests/5345/>,
>>          method:DELETE}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/<http://reviews.apache.org/api/review-requests/5345/>
>>             "
>>             2. method: "DELETE"
>>          3. diffs: {href:http://reviews.**apache.org/api/review-**
>>          
>> requests/5345/diffs/<http://reviews.apache.org/api/review-requests/5345/diffs/>,
>>          method:GET}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/**diffs/<http://reviews.apache.org/api/review-requests/5345/diffs/>
>>             "
>>             2. method: "GET"
>>          4. draft: {href:http://reviews.**apache.org/api/review-**
>>          
>> requests/5345/draft/<http://reviews.apache.org/api/review-requests/5345/draft/>,
>>          method:GET}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/**draft/<http://reviews.apache.org/api/review-requests/5345/draft/>
>>             "
>>             2. method: "GET"
>>          5. file_attachments: {href:http:/**/reviews.apache.org/api/**
>>          
>> review-requests/5345/file-**attachments/<http://reviews.apache.org/api/review-requests/5345/file-attachments/>,
>>          method:GET}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/**file-attachments/<http://reviews.apache.org/api/review-requests/5345/file-attachments/>
>>             "
>>             2. method: "GET"
>>          6. last_update: {href:http://**reviews.apache.org/api/review-**
>>          
>> requests/5345/last-update/<http://reviews.apache.org/api/review-requests/5345/last-update/>,
>>          method:GET}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/**last-update/<http://reviews.apache.org/api/review-requests/5345/last-update/>
>>             "
>>             2. method: "GET"
>>          7. repository: {href:http://**reviews.apache.org/api/**
>>          repositories/11/<http://reviews.apache.org/api/repositories/11/>,
>>          method:GET, title:shindig}
>>             1. href: 
>> "http://reviews.apache.**org/api/repositories/11/<http://reviews.apache.org/api/repositories/11/>
>>             "
>>             2. method: "GET"
>>             3. title: "shindig"
>>          8. reviews: {href:http://reviews.**apache.org/api/review-**
>>          
>> requests/5345/reviews/<http://reviews.apache.org/api/review-requests/5345/reviews/>,
>>          method:GET}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/**reviews/<http://reviews.apache.org/api/review-requests/5345/reviews/>
>>             "
>>             2. method: "GET"
>>          9. screenshots: {href:http://**reviews.apache.org/api/review-**
>>          
>> requests/5345/screenshots/<http://reviews.apache.org/api/review-requests/5345/screenshots/>,
>>          method:GET}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/**screenshots/<http://reviews.apache.org/api/review-requests/5345/screenshots/>
>>             "
>>             2. method: "GET"
>>          10. self: {href:http://reviews.**apache.org/api/review-**
>>          requests/5345/<http://reviews.apache.org/api/review-requests/5345/>,
>>          method:GET}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/<http://reviews.apache.org/api/review-requests/5345/>
>>             "
>>             2. method: "GET"
>>          11. submitter: {href:http://**reviews.apache.org/api/users/**
>>          ddumont/ <http://reviews.apache.org/api/users/ddumont/>,
>>          method:GET, title:ddumont}
>>             1. href: 
>> "http://reviews.apache.**org/api/users/ddumont/<http://reviews.apache.org/api/users/ddumont/>
>>             "
>>             2. method: "GET"
>>             3. title: "ddumont"
>>          12. update: {href:http://reviews.**apache.org/api/review-**
>>          requests/5345/<http://reviews.apache.org/api/review-requests/5345/>,
>>          method:PUT}
>>             1. href: "http://reviews.apache.**
>>             
>> org/api/review-requests/5345/<http://reviews.apache.org/api/review-requests/5345/>
>>             "
>>             2. method: "PUT"
>>          8. public: false
>>       9. status: "pending"
>>       10. summary: ""
>>       11. target_groups: []
>>       12. target_people: []
>>       13. testing_done: ""
>>       14. time_added: "2012-06-17 02:58:19"
>>    2. stat: "ok"
>>
>> Is there a setting I'm missing that controls the protocol?
>>
>> On Saturday, June 16, 2012 9:50:36 PM UTC-4, Dan Dumont wrote:
>>>
>>> Ahh ok.  So a bit more info:
>>> http://stackoverflow.com/**questions/228225/prevent-**
>>> redirection-of-xmlhttprequest<http://stackoverflow.com/questions/228225/prevent-redirection-of-xmlhttprequest>
>>>
>>>  If the origin of the URL conveyed by the Location header is same
>>>  origin with the XMLHttpRequest origin and the redirect does not
>>>  violate infinite loop precautions, transparently follow the
>>>  redirect while observing the same-origin request event rules.
>>>
>>> I'm assuming origin here works the same as normal SOP browser stuff, so
>>> http -> https will break.
>>> How are you crafting the api url for the post (not all the api calls
>>> fail, some of them are flaky occasionally though).  Do you use a protocol
>>> relative url?  
>>> //reviews.apache.org/path/to/**api<http://reviews.apache.org/path/to/api>
>>> or do you build it off of some variable in the config?
>>>
>>> On Saturday, June 16, 2012 9:37:11 PM UTC-4, Dan Dumont wrote:
>>>>
>>>> Didn't touch the apache config.
>>>> It's a http -> https redirect (no idea why the browser isn't simply
>>>> following it, do ajax requests eat the 301 errors?  I can't remember).
>>>> This is a brand new draft.
>>>>
>>>> On Saturday, June 16, 2012 9:31:26 PM UTC-4, Christian Hammond wrote:
>>>>>
>>>>> Hi Dan,
>>>>>
>>>>> It looks like it's redirecting to the URL it's already at? Is that
>>>>> right?
>>>>>
>>>>> Do any URLs but that cause a redirect?
>>>>>
>>>>> Was this an existing draft in the database, or a brand new one?
>>>>>
>>>>> And also, did you have to reconfigure the settings/Apache
>>>>> configuration at all, or is that all the same from before?
>>>>>
>>>>> Christian
>>>>>
>>>>> --
>>>>> Christian Hammond - chip...@chipx86.com
>>>>> Review Board - http://www.reviewboard.org
>>>>> VMware, Inc. - http://www.vmware.com
>>>>>
>>>>>
>>>>> On Sat, Jun 16, 2012 at 4:53 PM, Dan Dumont <ddum...@gmail.com> wrote:
>>>>>
>>>>>> Hi Christian,
>>>>>> I got things mostly up and running again by reconstructing the sql
>>>>>> tables in a new 1.5.5 install and then upgrading that.
>>>>>>
>>>>>> Having some difficulty at the site though.   Many different api
>>>>>> problems it looks like.
>>>>>> I can't publish drafts, getting a 301:
>>>>>>
>>>>>> OPTIONS /api/review-requests/5335/**draft/ HTTP/1.1
>>>>>> Host: reviews.apache.org
>>>>>> Connection: keep-alive
>>>>>> Access-Control-Request-Method: PUT
>>>>>> Origin: https://reviews.apache.org
>>>>>> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.11
>>>>>> (KHTML, like Gecko) Chrome/20.0.1132.34 Safari/536.11
>>>>>> Access-Control-Request-**Headers: origin, x-requested-with,
>>>>>> content-type, accept
>>>>>> Accept: */*
>>>>>> Accept-Encoding: gzip,deflate,sdch
>>>>>> Accept-Language: en-US,en;q=0.8
>>>>>> Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3
>>>>>> ------------------------------**------------------------------**
>>>>>> ------------------------------**-------
>>>>>> HTTP/1.1 301 Moved Permanently
>>>>>> Date: Sat, 16 Jun 2012 23:51:28 GMT
>>>>>> Server: Apache/2.2.20 (Ubuntu)
>>>>>> Location: https://reviews.apache.org/**api/review-requests/5335/**
>>>>>> draft/ <https://reviews.apache.org/api/review-requests/5335/draft/>
>>>>>> Vary: Accept-Encoding
>>>>>> Content-Encoding: gzip
>>>>>> Content-Length: 263
>>>>>> Keep-Alive: timeout=5, max=100
>>>>>> Connection: Keep-Alive
>>>>>> Content-Type: text/html; charset=iso-8859-1
>>>>>>
>>>>>> Can you help me troubleshoot this?
>>>>>>
>>>>>>  --
>>>>>> Want to help the Review Board project? Donate today at
>>>>>> http://www.reviewboard.org/**donate/<http://www.reviewboard.org/donate/>
>>>>>> Happy user? Let us know at 
>>>>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/>
>>>>>> -~----------~----~----~----~--**----~----~------~--~---
>>>>>> To unsubscribe from this group, send email to
>>>>>> reviewboard+unsubscribe@**googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
>>>>>> For more options, visit this group at http://groups.google.com/**
>>>>>> group/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en>
>>>>>>
>>>>>
>>>>>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to