I've tried restarting memcached, but it didn't help. reviewboard.log just shows that it's getting a 404 from Hg web server when trying to fetch the parent revision - which makes sense since it hasn't been committed - e.g. the patches are:
parent: diff -r 1 -r 2 file1.txt --- a/file1.txt Fri Jun 07 12:15:29 2013 -0600 +++ b/file1.txt Fri Jun 07 21:02:26 2013 +0100 [diff contents] review_diff: diff -r 2 -r 3 file2.txt --- a/file2.txt Fri Jun 07 12:15:29 2013 -0600 +++ b/file2.txt Fri Jun 07 21:02:26 2013 +0100 [diff contents] Only r1 exists in the repository. I've just replicated the problem on the demo server - see http://demo.reviewboard.org/r/12105/diff/#index_header . Since people only started complaining about this a few hours after I upgraded to 1.7.9 I'm /assuming/ it's new. -- Bruce On 10 June 2013 10:56, Christian Hammond <[email protected]> wrote: > Hi Bruce, > > There's only two change to Mercurial since 1.7.6. > > One has to do with fixes to the Mercurial version checking. That fix, > though, has to do with handling the different ways of checking the Mercurial > version and working around a breakage we had in some setups, and I wouldn't > expect it to have an impact on file existence checking in any way. > > The other validates the repository during repo creation, and catches errors > accessing the repository during file fetching. It would show you a different > error than what you're getting, though. > > Can you repeat the problem and look in reviewboard.log to see if there's any > interesting error messages? > > One other thing, just to try it. Can you clear your memcached and try again? > > Christian > > -- > Christian Hammond - [email protected] > Review Board - http://www.reviewboard.org > Beanbag, Inc. - http://www.beanbaginc.com > > > On Mon, Jun 10, 2013 at 2:03 AM, Bruce Cran <[email protected]> wrote: >> >> Hi Christian, >> >> I upgraded from 1.7.6, and this breaks both when using RBTools and >> when uploading patches via the Web interface. I've not upgraded >> RBTools, but someone else tried using the newer version and found it >> was still broken. >> >> -- >> Bruce Cran >> >> >> >> On 10 June 2013 09:19, Christian Hammond <[email protected]> wrote: >> > Hi Bruce, >> > >> > Can you tell me what version of Review Board you were using before? >> > Also, >> > did you upgrade RBTools before this broke? >> > >> > I don't see any changes to our Mercurial support in the past two >> > releases of >> > Review Board, aside from one to do verification when adding a new >> > repository. >> > >> > It's possible some code changed in RBTool 0.5.1 that broke this, though, >> > if >> > you're running that. A quick way to check would be to downgrade RBTools >> > to >> > 0.5.0 and try again. >> > >> > Christian >> > >> > -- >> > Christian Hammond - [email protected] >> > Review Board - http://www.reviewboard.org >> > Beanbag, Inc. - http://www.beanbaginc.com >> > >> > >> > On Fri, Jun 7, 2013 at 1:11 PM, Bruce Cran <[email protected]> wrote: >> >> >> >> There seems to be a regression in 1.7.9 with mercurial parent diffs: if >> >> a >> >> file is modified in the review diff that wasn't changed in the parent >> >> diff, >> >> then Review Board generates the error "Error: The file 'file2.txt' >> >> (r12345678) could not be found in the repository". >> >> >> >> -- >> >> Bruce Cran >> >> >> >> -- >> >> Want to help the Review Board project? Donate today at >> >> http://www.reviewboard.org/donate/ >> >> Happy user? Let us know at http://www.reviewboard.org/users/ >> >> -~----------~----~----~----~------~----~------~--~--- >> >> To unsubscribe from this group, send email to >> >> [email protected] >> >> For more options, visit this group at >> >> http://groups.google.com/group/reviewboard?hl=en >> >> --- >> >> You received this message because you are subscribed to the Google >> >> Groups >> >> "reviewboard" group. >> >> To unsubscribe from this group and stop receiving emails from it, send >> >> an >> >> email to [email protected]. >> >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> >> >> > >> > >> > -- >> > Want to help the Review Board project? Donate today at >> > http://www.reviewboard.org/donate/ >> > Happy user? Let us know at http://www.reviewboard.org/users/ >> > -~----------~----~----~----~------~----~------~--~--- >> > To unsubscribe from this group, send email to >> > [email protected] >> > For more options, visit this group at >> > http://groups.google.com/group/reviewboard?hl=en >> > --- >> > You received this message because you are subscribed to the Google >> > Groups >> > "reviewboard" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> > an >> > email to [email protected]. >> > For more options, visit https://groups.google.com/groups/opt_out. >> > >> > >> >> >> >> -- >> -- >> Bruce Cran >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> [email protected] >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > -- -- Bruce Cran -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
