I don't think any of us have worked with diff parsing recently enough to
know the answer to whether the implementation handles that off the top of
our heads. If git diff produces these files, and Review Board doesn't parse
them correctly, then yes, we should probably fix it. The technical answers
you seek are in reviewboard/scmtools/git.py

-David


On Wed, Nov 13, 2013 at 4:32 PM, Matthew Woehlke
<mwoehlke.fl...@gmail.com>wrote:

> So, I've been working on a git-specific helper script for posting reviews
> which, among other things, includes the git log in the diff.
>
> For a while, I was seeing a bug where the log shows up incorrectly when
> posted from a Windows machine. I finally determined that this is caused by
> the diff quoting the file paths, i.e.:
>
> diff --git "a/.gitlog" "b/.gitlog"
> new file mode 100644
> index 0000000..<sha>
> --- /dev/null
> +++ "b/.gitlog"
> ...diffs...
>
> It seems that 'git diff' quotes the file names if they contain characters
> that might otherwise confuse the diff parser (what's not seen here is that
> the original file names were e.g. 'C:\Users\My User\Temporary Files\..."
> and have had string substitution performed to get to ".gitlog").
>
> What I'm wondering is, if a file name actually needs to be quoted, does RB
> correctly parse the quoted name? And in particular, should it also be
> handling the above case "better" than it seems to be doing?
>
> --
> Matthew
>
> --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- You received this message because you are subscribed to the Google
> Groups "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to