I think the issues with setup-repo and list-repo-types are just a simple
bug with our command-line handling.

-David


On Wed, Apr 23, 2014 at 3:16 PM, Dan Schmitt <dan.schm...@gmail.com> wrote:

> I must be missing something then. I have a local copy of the
> perforce tree that has all the files in the change list I want to
> create, and rbt isn't finding it.
>
> $ rbt setup-repo
> Enter the Review Board server URL: http://172.16.149.128/reviewboard/r/
> CRITICAL: 'Namespace' object has no attribute 'p4_client'
>
> which looks like the same p4_client attribute error I get when
> doing rbt list-repo-types
>
> It may be something goofy on OSX with my python (it's a 2.6.1
> and seems to have P4 and P4API installed) and installed with
> easy_install as per
>
> http://www.reviewboard.org/docs/rbtools/dev/#installation
>
> Any help diagnosing/resolving/bypassing this would be outstanding.
> (a sample .reveiwboardrc that works with p4 might help if somebody
> has one laying about.)
>
> I'll put the ticket request but can get by posting review requests from
> a directory with the p4 client files in it as well.
>
>          Dan S.
>
>
> On Wednesday, April 23, 2014 5:58:37 PM UTC-4, David Trowbridge wrote:
>
>> Right now, rbtools is not well suited to posting review requests for
>> submitted changes without a working directory. This should work fine if you
>> create a p4 client and run rbt from within that directory.
>>
>> We should improve that, however. Can you file a bug about this?
>>
>> -David
>>
>>
>> On Tue, Apr 22, 2014 at 7:46 PM, Dan Schmitt <dan.s...@gmail.com> wrote:
>>
>>> I can get the reviewboard web interface to see my p4 repository (and it
>>> finds
>>> the change descriptions if I try to create a a new review request.)
>>>
>>> I'm seeing:
>>>
>>> Traceback (most recent call last):
>>>   File "/usr/local/bin/rbt", line 8, in <module>
>>>     load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()
>>>   File 
>>> "/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/main.py",
>>> line 134, in main
>>>     command.run_from_argv([RB_MAIN, command_name] + args)
>>>   File "/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
>>> egg/rbtools/commands/__init__.py", line 422, in run_from_argv
>>>     exit_code = self.main(*args) or 0
>>>   File "/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
>>> egg/rbtools/commands/list_repo_types.py", line 12, in main
>>>     print_clients(self.options)
>>>   File "/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
>>> egg/rbtools/clients/__init__.py", line 356, in print_clients
>>>     repository_info = tool.get_repository_info()
>>>   File "/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
>>> egg/rbtools/clients/perforce.py", line 183, in get_repository_info
>>>     p4_info = self.p4.info()
>>>   File "/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
>>> egg/rbtools/clients/perforce.py", line 73, in info
>>>     split_lines=True)
>>>   File "/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
>>> egg/rbtools/clients/perforce.py", line 101, in run_p4
>>>     if self.options.p4_client:
>>> AttributeError: 'Namespace' object has no attribute 'p4_client'
>>>
>>> from rbt list-repo-types.
>>>
>>> I don't have permission to make counters (which seems to be a suggested
>>> work around for getting rbt post to work.)
>>>
>>> rbt diff -d <change number that worked in the web interface>
>>> rbt post -d <change number that worked in the web interface>
>>>
>>> says:
>>>
>>> ERROR: The current directory does not contain a checkout from a
>>> supported source code repository.
>>>
>>> I know the old p4 server means I don't have the shelve option.  We are
>>> currently pushing changes
>>> to a development branch then merging that into a release branch.   Is
>>> there some trick I'm missing
>>> for getting the rbt to build a diff for an already submitted p4 change?
>>>
>>>       Dan S.
>>>
>>>
>>>  --
>>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>>> ---
>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>> ---
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>>
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to