Thanks Christian! I appreciate it! On Wednesday, June 4, 2014 10:47:20 PM UTC-4, Christian Hammond wrote: > > Hi Alan, > > Looks like you set ‘fieldset_id’ and not ‘field_id’, which would cause > this problem. > > Christian > > -- > Christian Hammond - [email protected] <javascript:> > Review Board - http://www.reviewboard.org > Beanbag, Inc. - http://www.beanbaginc.com > > On June 4, 2014 at 4:55:41 PM, Alan Ray ([email protected] <javascript:>) > wrote: > > Is there a trick to getting a custom field to save/load? > > I followed the directions here ( > http://www.reviewboard.org/docs/manual/dev/extending/extensions/hooks/review-request-fields-hook/). > > I have an extension with a field that appears in one of the main fieldsets > (information or reviewers). > > I can edit the field, and press 'enter' to make the field non-editable > with the new value in it. But the value is not being saved. If I reload the > review, the field value is blank again. If I publish the review, it > publishes with no changes made. I went in and overrode the save_value() and > load_value() functions with logging messages. As far as I can tell, they > are never being called. render_value() is being called, but that obviously > doesn't help me much without save/load functionality. > > From the documentation in reviews/fields.py, it looks like save/load > should come automatically with the BaseEditableField class. Is there > something I'm missing? My code is really simple: > > class TrelloCardField(BaseEditableField): > fieldset_id = 'my_trello_card' > label = 'Trello Card' > > class MyReviewboardExtension(Extension): > is_configurable = False > def initialize(self): > ReviewRequestFieldsHook(self, 'reviewers', [TrelloCardField)] > > Thanks, > Alan > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > For more options, visit https://groups.google.com/d/optout. > >
-- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
