Thanks for the explanation David,

-amac

On Tuesday, November 25, 2014 3:37:17 PM UTC-8, David Trowbridge wrote:
>
> Ah, I see what's going on. It's being filtered out because it's not 
> included in any of the changed regions in the new diff. This happens so 
> that we can filter out unrelated changes from other commits that happen in 
> between the diffs.
>
> It's not ideal, but I don't know that we can do anything about this 
> without bringing back all of the other unrelated changes.
>
> -David
>
> On Tue, Nov 25, 2014 at 10:00 AM, Andrew MacLeod <free...@gmail.com 
> <javascript:>> wrote:
>
>> Thanks David although that is not what not I am seeing now that I tracked 
>> down the review again.
>>
>> The interdiff between the revision where the code was removed and any 
>> revision after it got added back does not show as an added diff. 
>>
>> One correction to my original description, the code was added back in 
>> revision 6. I have added screenshots to show the behavior. Screenshot of 
>> the changes from the original to #1 (where the code was removed), 5-6 where 
>> the code was added back in and finally 1-6.
>>
>> If I understand you explanation below then this is a bug and the addition 
>> from 1-6 should be highlighted? This is Review Board version 2.0.11 if that 
>> makes a difference.
>> Thanks,
>>
>> -amac
>>
>> On Thursday, November 20, 2014 4:40:48 PM UTC-8, David Trowbridge wrote:
>>>
>>> This is the case because if you apply rev #2 to the upstream code, those 
>>> lines are present, and if you apply rev #6 to the upstream code, those 
>>> lines are also present (so there's no difference between them). If you view 
>>> the interdiff between 1 and 6, you should see those lines as added.
>>>
>>> -David
>>>
>>> On Thu, Nov 20, 2014 at 4:25 PM, Andrew MacLeod <free...@gmail.com> 
>>> wrote:
>>>
>>>> The scenario is as follow.
>>>>
>>>> In the first diff posting (rev #1) of a review, lines 5-10 are removed 
>>>> in one particular file. There are lots of other changes in this file and 
>>>> others. 
>>>>
>>>> In the second diff posting (rev #2) of the review, the lines are added 
>>>> back in.
>>>>
>>>> We get several more diff postings on this review until we are at rev#6. 
>>>> Now if you look at the
>>>> inter-diff changes from rev #2 -> rev #6, the addition of lines 5-10 
>>>> does *not* show as an addition
>>>> (ie. in green) on the right hand panel of the diff screen. 
>>>>
>>>> I can argue why that is the case but my question is this intended 
>>>> behavior? 
>>>>
>>>> Thanks,
>>>>
>>>> -amac
>>>>
>>>> -- 
>>>> Get the Review Board Power Pack at http://www.reviewboard.org/
>>>> powerpack/
>>>> ---
>>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>>> ---
>>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>>> --- 
>>>> You received this message because you are subscribed to the Google 
>>>> Groups "reviewboard" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send 
>>>> an email to reviewboard...@googlegroups.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>>
>>>  -- 
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to