I turned off DEBUG, no change in diff generation problem. I am creating a review request by clicking New Review Request, then using the Create from existing commit on [combobox showing branches and trunk, I selected trunk]. I single-click in the list of changes for the selected branch. I get a new review.
There are no errors in the javascript Console, nothing on the HTML5 side looks like it broke. There are no errors loading any assets on the Network tab of the browser debug tools window, and there's nothing at all in the console log. Using the DOM inspector I see an empty div, 100% width, 2 pixel height, no content inside that div at all. It looks like the python/django side is not generating any diff output. I am a competent Python developer but new to this codebase, and not familiar with Django. I might see if I can add any logging to the code. Just to rule out stupid mistakes by me, are there any diff-generation binary tools that ReviewBoard relies on to generate the html diff output? Could I be missing something? W On Tuesday, January 26, 2016 at 3:45:31 PM UTC-5, David Trowbridge wrote: > > First of all, DEBUG is meant for development and having it set to True for > production will break things. > > Can you clarify how you're uploading your diff? Are you using rbtools? > Posting a patch by hand? Creating a review request for a committed change > from /r/new ? > > Can you look in the browser's javascript console to see if there are any > front-end errors? > > -David > > On Tue, Jan 26, 2016 at 12:37 PM Warren Postma <warren...@gmail.com > <javascript:>> wrote: > >> Okay got some logging. Appears to have worked fine. >>> >>> >>> 2016-01-26 20:34:37,050 - DEBUG - - Logging to >>> /opt/reviewboard/ramsoft/logs/reviewboard.log with a minimum level of DEBUG >>> 2016-01-26 20:34:40,662 - DEBUG - - Logging to >>> /opt/reviewboard/ramsoft/logs/reviewboard.log with a minimum level of DEBUG >>> 2016-01-26 20:34:48,635 - DEBUG - None - wpostma - /reviews/r/3/diff/ - >>> Generating diff viewer page for filediff id 3 >>> 2016-01-26 20:34:48,648 - DEBUG - None - wpostma - /reviews/r/3/diff/ - >>> Begin: Generating diff file info for diffset id 3 >>> 2016-01-26 20:34:48,653 - DEBUG - None - wpostma - /reviews/r/3/diff/ - >>> End: Generating diff file info for diffset id 3 >>> 2016-01-26 20:34:48,653 - DEBUG - None - wpostma - /reviews/r/3/diff/ - >>> Generating diff file info for diffset id 3 took 0.005346 seconds >>> 2016-01-26 20:34:48,658 - DEBUG - None - wpostma - /reviews/r/3/diff/ - >>> Done generating diff viewer page for filediff id 3 >>> 2016-01-26 20:35:22,029 - INFO - - Reloading logging settings >>> 2016-01-26 20:35:22,030 - DEBUG - - Logging to >>> /opt/reviewboard/ramsoft/logs/reviewboard.log with a minimum level of DEBUG >> >> >> No information at all in the logs shows me why there's nothing on the screen >> and why the diff is empty. >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -David > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
