Hi Christian,

Than you for the information,
and that's the plan I'm doing right now.

I created a BASH script wrapper on top of rbt command line tool
to handle "rbt post" that contains binary changes,
and tar all the changed binaries into a single tarball to attach to a 
review.

Some side-notes:
While developing the wrapper script,
I found out there's no "rbt attach" update commands to update specific 
attachment.
I see "Update" feature is available on Web UI.

Another thing is SVN property changes handling (svn propset, proplist).
"rbt diff / rbt patch" is able to correctly handling the changes in "SVN 
property".

eg. (rbt diff)
Index: x86_64/dd
===================================================================
--- x86_64/dd    (revision 7144)
+++ x86_64/dd    (working copy)

Property changes on: x86_64/dd
___________________________________________________________________
Added: opensource
## -0,0 +1 ##
+ON
\ No newline at end of property

And when I do "rbt patch",
the corresponding SVN property changes applied correctly.

But from the WebUI,
I can't find any trace to the changed file "dd".
Unlike binary file change,
the webUI diff would still show:
This is a binary file. The content cannot be displayed.

I'd suggest it should display the same as "rbt diff".






Rick



On Friday, April 22, 2016 at 4:33:33 PM UTC-7, Christian Hammond wrote:
>
> Hi Rick,
>
> There isn't currently a standard for binary files in diffs, and Subversion 
> has no support whatsoever. You can attach binary files to review requests 
> as file attachments.
>
> Marking Ship It doesn't merge changes, so that still has to be done 
> locally. Presumably, you have those binary files in your working directory, 
> and can commit them along with the code changes.
>
> We have plans for more intelligently handling binary files, and are aiming 
> to provide that as part of Review Board 3.5 (3.0 is in development right 
> now).
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> On Fri, Apr 22, 2016 at 12:29 PM, Rick Liu <totoro...@gmail.com 
> <javascript:>> wrote:
>
>>
>> Environment:
>> OS: Ubuntu 14.04 x64
>> Reviewboard: 2.5.4
>> Python 2.7.6
>> RBTools 0.7.5
>>
>>
>> We use "rbt post" to post a review contains binary file.
>> The web front-end correctly identified the file as binary file in diff 
>> view.
>> But:
>> 1.
>> I can't find any link to download the new binary file to be submitted.
>> 2.
>> When I "ship-it" to submit the review,
>> it failed to be merged into SVN.
>>
>> I googled the binary support for reviewboard.
>> Some said yes and some said no,
>> so I'm confused here.
>>
>> Thanks,
>>
>> Rick
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to