Correct, webhooks won't be responsible for this.
I don't know where you're looking to actually factor in the Ship It logic,
though. If you're looking to block commits before they land upstream, then
you'll need to be running a repository under your control capable of using
things like a post-receive/post-commit hook (GitHub and such does not have
support for adding these to block commits) along with the approval hook I
documented containing the logic needed to check for multiple commits.
(I will be on vacation for the remainder of the week, starting tomorrow
morning, so I won't be able to help any more with this until I get back,
but hopefully that information helps.)
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>
On Thu, Sep 29, 2016 at 8:12 AM, pg007 <penguin02...@gmail.com> wrote:
> Hi Christian,
> We have developers would like two approvals (ship it) on critical
> application. To clarify, the following methods do not involve the use of
> webhooks, correct?
> On Wednesday, September 28, 2016 at 4:43:37 PM UTC-4, Christian Hammond
>> Knowing more about what you're aiming to do would help, but there are a
>> couple things you can do by making use of our API and (possibly) extension
>> 1) In response to a webhook, you could query the API and find all the
>> reviews for the review request, checking how many Ship Its there are. See
>> 2) You could write an extension defining a custom approval logic (which
>> indicates whether the "approved" flag is set to true or false in the
>> API/webhook payload for a review request) to require more than one Ship It.
>> See https://www.reviewboard.org/docs/manual/dev/extending/ex
>> Christian Hammond
>> President/CEO of Beanbag <https://www.beanbaginc.com/>
>> Makers of Review Board <https://www.reviewboard.org/>
>> On Wed, Sep 28, 2016 at 1:28 PM, pg007 <pengui...@gmail.com> wrote:
>>> Is it possible to enforce or check a RB to have more than one 'ship it'?
>>> I looked into the web-hooks but I am not sure which does this belong to.
>>> Webhooks can be triggered by the following events:
>>> - Review requests being published (review_request_published).
>>> - Review requests being closed (review_request_closed).
>>> - Reviews being published (review_published).
>>> - Review replies being published (reply_published).
>>> - All of the above (*).
>>> Supercharge your Review Board with Power Pack:
>>> Want us to host Review Board for you? Check out RBCommons:
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
Supercharge your Review Board with Power Pack:
Want us to host Review Board for you? Check out RBCommons:
Happy user? Let us know! https://www.reviewboard.org/users/
You received this message because you are subscribed to the Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email
For more options, visit https://groups.google.com/d/optout.