On Tue, Jun 4, 2019 at 1:31 PM 'Eric Johnson' via Review Board Community <reviewboard@googlegroups.com> wrote: > > Hi Christian, > > Thanks so much for the response! As near as I can tell, ReviewBoard "just > works" for the teams that use it here, so we're grateful for the quality work. > > The issue appears to be solved at this point, and it looks like operator > error. More details below. > > On Friday, May 31, 2019 at 12:58:31 AM UTC-7, Christian Hammond wrote: >> >> Hi Eric, >> >> Can you verify that rbintegrations was also packaged and that its extension >> is enabled? >> >> >> We really don't advise installing from our tarballs, as we build the eggs >> and wheels with a particular setup to ensure they're packaged just right. It >> is of course possible to build with tarballs, but there are differences. The >> process of building eggs/wheels can result in changes to the required >> dependencies and to some of the build steps. It'd be best if the "source" >> could be the wheel, just extracted. > > > Unfortunately, I don't see that installing from the "whl" files or the "egg" > files is really used at all on Gentoo. It is fairly straightforward to make > sure I get the dependencies right, since I had to encode the dependencies > into the Gentoo package ebuild files. As for getting the files right, a > recursive compare of the pip install vs. the Gentoo install shows that they > end up the same with the packages I created. > > The one challenge I observed with the ReviewBoard packages was that > rbintegrations included a small handfule of binary files that I needed to > copy over and add to the unpacked source. > > As for why my changes were not working when I wrote you initially, it appears > that I forgot to reset my virtual machine for testing purposes, and was > instead dealing with incremental changes, and it didn't work. When I reset my > VM, and applied the upgrade to the Gentoo packages on a "clean" install of > the 2.5.18 version, the end-result worked just fine. > > Thanks for your help. Your questions prodded me to keep looking, to make sure > I could properly describe the problem, and that got me to find my mistake. >
For what it's worth, you might find my Fedora packaging to be useful in guiding you here. Realistically, you probably want to do what I did and just bundle the rbintegrations tarball with the ReviewBoard build. The Fedora packaging is here: https://src.fedoraproject.org/rpms/ReviewBoard/tree/3.0 -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAFAoxCmdOGs_7H1ymKJmRW_aQ8qmEk1dOfGT6BN429yD1d%3DKEA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
