Hi Eric, Yeah, it's cyclical. rbintegrations needs the Review Board source to build (which is why Review Board does *not* depend on rbintegrations at `setup.py develop` time), but we want to auto-install rbintegrations when installing Review Board, which is why Review Board has a dependency on it. This is not great, but since *most* consume our packages from our own builds, most people don't have to worry about it. We opted to keep rbintegrations separate so that we could maintain it across Review Board releases, without forcing people to upgrade Review Board to get, say, the latest Slack fixes.
Christian On Tue, Jun 4, 2019 at 2:27 PM 'Eric Johnson' via Review Board Community < reviewboard@googlegroups.com> wrote: > Hi Stephen, > > On Tue, Jun 4, 2019 at 1:12 PM Stephen Gallagher < > step...@gallagherhome.com> wrote: > >> On Tue, Jun 4, 2019 at 1:31 PM 'Eric Johnson' via Review Board >> Community <reviewboard@googlegroups.com> wrote: >> > The one challenge I observed with the ReviewBoard packages was that >> rbintegrations included a small handfule of binary files that I needed to >> copy over and add to the unpacked source. >> > >> > As for why my changes were not working when I wrote you initially, it >> appears that I forgot to reset my virtual machine for testing purposes, and >> was instead dealing with incremental changes, and it didn't work. When I >> reset my VM, and applied the upgrade to the Gentoo packages on a "clean" >> install of the 2.5.18 version, the end-result worked just fine. >> > >> > Thanks for your help. Your questions prodded me to keep looking, to >> make sure I could properly describe the problem, and that got me to find my >> mistake. >> > >> >> For what it's worth, you might find my Fedora packaging to be useful >> in guiding you here. Realistically, you probably want to do what I did >> and just bundle the rbintegrations tarball with the ReviewBoard build. >> >> The Fedora packaging is here: >> https://src.fedoraproject.org/rpms/ReviewBoard/tree/3.0 > > > I almost had to go down that path. Fortunately, I was able to keep them > separate. They have an oddly cyclical relationship. As near as I can tell, > in the source, each depends on the existence of the other in setup.py . > Fortunately, when packaging for Gentoo, I simply removed all the setup > activities (making it equivalent to the whl files), which breaks the > dependency cycle. > > Eric. > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/reviewboard/CANu9%3DNc-dqF66agep9dQgsqG3RH%3DYttkutKjwd6tnYPfXE_PRQ%40mail.gmail.com > <https://groups.google.com/d/msgid/reviewboard/CANu9%3DNc-dqF66agep9dQgsqG3RH%3DYttkutKjwd6tnYPfXE_PRQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAE7VndnbKYDH5vq2i_%2B_WE3840rTNLL_3Jig1Df8AiiFLL0nHg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
