-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122478
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml
 (line 145)
<https://reviews.apache.org/r/44272/#comment184490>

    Can be removed - not being used.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml
 (line 173)
<https://reviews.apache.org/r/44272/#comment184488>

    Does not seem right. Agent reports public and internal host names and that 
should be used instead of asking users to enter the public host name.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml
 (line 87)
<https://reviews.apache.org/r/44272/#comment184480>

    For me on a plain vagrant VM install fails unless I edit epel.repo file to 
change baseurl from https to http



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py
 (line 1)
<https://reviews.apache.org/r/44272/#comment184484>

    Remove this alert and add a WEB alert against zepplin listen port 9995



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
 (line 61)
<https://reviews.apache.org/r/44272/#comment184483>

    This is being executed as root. So the file created cannot be written by 
later commands. E.g. error:
    
    Execution of 
'/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh
 /usr/hdp/current/zeppelin-server/lib c6402.ambari.apache.org 9083 10001 
c6402.ambari.apache.org 9995 True 
/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5.0.0/package 
/usr/jdk64/jdk1.8.0_40 >> /var/log/zeppelin/zeppelin-setup.log' returned 1. 
-bash: /var/log/zeppelin/zeppelin-setup.log: Permission denied



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py
 (line 56)
<https://reviews.apache.org/r/44272/#comment184489>

    Not being used - can be deleted.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py
 (line 64)
<https://reviews.apache.org/r/44272/#comment184487>

    Do we really need the public host? The code using this parameter is 
executed on the same host that runs Zeppelin.



ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml 
(line 24)
<https://reviews.apache.org/r/44272/#comment184476>

    version should be 0.6.0.2.5



ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml 
(line 25)
<https://reviews.apache.org/r/44272/#comment184477>

    folder should be 0.6.0. common-services is a common definition of service 
that should not be associated with specific HDP versions


- Sumit Mohanty


On March 7, 2016, 7:09 p.m., Renjith Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 7:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15265
>     https://issues.apache.org/jira/browse/AMBARI-15265
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/alerts.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml
>  PRE-CREATION 
>   contrib/views/pom.xml 627552a 
>   contrib/views/zeppelin/pom.xml PRE-CREATION 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
>  PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44272/diff/
> 
> 
> Testing
> -------
> 
> - manual testing in vm
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Reply via email to