> On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py, > > line 46 > > <https://reviews.apache.org/r/44272/diff/2/?file=1283231#file1283231line46> > > > > The rpm is responsible for creating the user.
not updated in rev3 > On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py, > > line 49 > > <https://reviews.apache.org/r/44272/diff/2/?file=1283231#file1283231line49> > > > > This is bound to fail in firewalled networks. Will need to figure out a > > way to include these in HDP UTILS and still be able to pip-install them. > > > > We cannot ship these packages with Ambari due to BSD license on numpy, > > scipy, pandas, scikit-learn, which has an advertisement clause. removed `pip install` for additional python pacakges > On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py, > > line 70 > > <https://reviews.apache.org/r/44272/diff/2/?file=1283232#file1283232line70> > > > > spark_version is not defined in case of an exception. will fix it in the follow up patch > On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py, > > line 165 > > <https://reviews.apache.org/r/44272/diff/2/?file=1283231#file1283231line165> > > > > Use a marker file on the file system to know if the first-time setup > > was successful. earier we had a marker file to check for first-time setup, removed after a review comment - Renjith ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44272/#review122348 ----------------------------------------------------------- On March 8, 2016, 7:18 p.m., Renjith Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44272/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 7:18 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-15265 > https://issues.apache.org/jira/browse/AMBARI-15265 > > > Repository: ambari > > > Description > ------- > > - add service defnition for Apache Zeppelin > - add support for Zeppelin view in Ambari > - add alert config > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml > PRE-CREATION > contrib/views/pom.xml 627552a > contrib/views/zeppelin/pom.xml PRE-CREATION > > contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java > PRE-CREATION > contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION > contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION > contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/44272/diff/ > > > Testing > ------- > > - manual testing in vm > > > Thanks, > > Renjith Kamath > >
