> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py,
> >  line 1
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283230#file1283230line1>
> >
> >     Remove this alert and add a WEB alert against zepplin listen port 9995

will update it in the follow-up patch


> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py,
> >  line 61
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283231#file1283231line61>
> >
> >     This is being executed as root. So the file created cannot be written 
> > by later commands. E.g. error:
> >     
> >     Execution of 
> > '/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh
> >  /usr/hdp/current/zeppelin-server/lib c6402.ambari.apache.org 9083 10001 
> > c6402.ambari.apache.org 9995 True 
> > /var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5.0.0/package 
> > /usr/jdk64/jdk1.8.0_40 >> /var/log/zeppelin/zeppelin-setup.log' returned 1. 
> > -bash: /var/log/zeppelin/zeppelin-setup.log: Permission denied

fixed


> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py,
> >  line 64
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283232#file1283232line64>
> >
> >     Do we really need the public host? The code using this parameter is 
> > executed on the same host that runs Zeppelin.

removed


> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py,
> >  line 56
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283232#file1283232line56>
> >
> >     Not being used - can be deleted.

removed


> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml,
> >  line 145
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283227#file1283227line145>
> >
> >     Can be removed - not being used.

removed


- Renjith


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122478
-----------------------------------------------------------


On March 8, 2016, 7:18 p.m., Renjith Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 7:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15265
>     https://issues.apache.org/jira/browse/AMBARI-15265
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml
>  PRE-CREATION 
>   contrib/views/pom.xml 627552a 
>   contrib/views/zeppelin/pom.xml PRE-CREATION 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
>  PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44272/diff/
> 
> 
> Testing
> -------
> 
> - manual testing in vm
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Reply via email to