----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44700/#review123386 -----------------------------------------------------------
contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties (line 2) <https://reviews.apache.org/r/44700/#comment185641> Do you think it will be better if we add these log files into their own folder inside the /var/log/ambari-server directory. Like, hive-view logs can be inside: /var/log/ambari-server/hive-view/hive-view.log In future if a developer wants to add some other logs along with the view log, it will be compartmentalized inside its own directory. contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties (line 8) <https://reviews.apache.org/r/44700/#comment185640> Modify log level in all the view log4j properties to INFO - DIPAYAN BHOWMICK On March 11, 2016, 7:52 a.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44700/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 7:52 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, > and Yusaku Sako. > > > Bugs: AMBARI-14084 > https://issues.apache.org/jira/browse/AMBARI-14084 > > > Repository: ambari > > > Description > ------- > > Earlier : > logs of all the views used to go into ambari-server.log which caused problem > in debugging views. > > In this Patch: > ViewRegistry now looks for file > view.log4j.properties using the view archive classloader and loads all the > log4j properties in it using PropertyConfigurator. Separate log4j > configuraiton files added to all core views. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > e31037e > contrib/views/capacity-scheduler/pom.xml 5569859 > contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties > PRE-CREATION > contrib/views/files/pom.xml ccea5ab > contrib/views/files/src/main/resources/view.log4j.properties PRE-CREATION > contrib/views/hive/pom.xml 1f150ff > contrib/views/hive/src/main/resources/view.log4j.properties PRE-CREATION > contrib/views/jobs/pom.xml d797ebd > contrib/views/jobs/src/main/resources/view.log4j.properties PRE-CREATION > contrib/views/pig/pom.xml 97160cc > contrib/views/pig/src/main/resources/view.log4j.properties PRE-CREATION > contrib/views/slider/pom.xml 608988f > contrib/views/slider/src/main/resources/view.log4j.properties PRE-CREATION > contrib/views/storm/src/main/resources/view.log4j.properties PRE-CREATION > contrib/views/tez/pom.xml 8e82c5e > contrib/views/tez/src/main/resources/view.log4j.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/44700/diff/ > > > Testing > ------- > > Manual Testing Done. > separate log files for each view was properly generated. Also the log level > was getting properly set. > > > Thanks, > > Nitiraj Rathore > >
