-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/
-----------------------------------------------------------
(Updated March 15, 2016, 12:20 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, and
Yusaku Sako.
Changes
-------
New patch submitted after incorporating changes in the comments.
1. now log level is INFO for views
2. log directory is separate for all views.
Bugs: AMBARI-14084
https://issues.apache.org/jira/browse/AMBARI-14084
Repository: ambari
Description
-------
Earlier :
logs of all the views used to go into ambari-server.log which caused problem in
debugging views.
In this Patch:
ViewRegistry now looks for file
view.log4j.properties using the view archive classloader and loads all the
log4j properties in it using PropertyConfigurator. Separate log4j
configuraiton files added to all core views.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
e31037e
contrib/views/capacity-scheduler/pom.xml 5569859
contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties
PRE-CREATION
contrib/views/files/pom.xml ccea5ab
contrib/views/files/src/main/resources/view.log4j.properties PRE-CREATION
contrib/views/hive/pom.xml 1f150ff
contrib/views/hive/src/main/resources/view.log4j.properties PRE-CREATION
contrib/views/jobs/pom.xml d797ebd
contrib/views/jobs/src/main/resources/view.log4j.properties PRE-CREATION
contrib/views/pig/pom.xml 97160cc
contrib/views/pig/src/main/resources/view.log4j.properties PRE-CREATION
contrib/views/slider/pom.xml 608988f
contrib/views/slider/src/main/resources/view.log4j.properties PRE-CREATION
contrib/views/storm/src/main/resources/view.log4j.properties PRE-CREATION
contrib/views/tez/pom.xml 8e82c5e
contrib/views/tez/src/main/resources/view.log4j.properties PRE-CREATION
Diff: https://reviews.apache.org/r/44700/diff/
Testing
-------
Manual Testing Done.
separate log files for each view was properly generated. Also the log level was
getting properly set.
Thanks,
Nitiraj Rathore
