> On March 14, 2016, 5:47 p.m., Di Li wrote: > > Ship It! > > Keta Patel wrote: > Thank you Di! > > Di Li wrote: > can you reattach the latest build via the "Update Diff" option? Your > AMBARI-15310_Mar10.patch is not up to download via review board.
Hello Di, I have attached the latest patch in "Update Diff". Thank you! - Keta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44457/#review123464 ----------------------------------------------------------- On March 15, 2016, 4:07 p.m., Keta Patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44457/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 4:07 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-15310 > https://issues.apache.org/jira/browse/AMBARI-15310 > > > Repository: ambari > > > Description > ------- > > In Ambari UI, navigate to Hosts and click on the hostname where the service > is installed. The summary page displays the list of services installed. > Observe that longer service names does not display well. The refresh icon > etc. spills to the next line (see attachment "Original spacing with long > service name"). > Also, note the indentation of the last button for Clients does not align well > with the buttons above it. > > > Diffs > ----- > > ambari-web/app/models/host_component.js a325113 > ambari-web/app/styles/application.less 755dff2 > ambari-web/app/templates/main/host/details/host_component.hbs 60031de > ambari-web/app/templates/main/host/summary.hbs 11b4861 > ambari-web/test/models/host_component_test.js 202f5c5 > > Diff: https://reviews.apache.org/r/44457/diff/ > > > Testing > ------- > > FIX: > This issue is simialr to AMBARI-11670 where the spacing for each component > was fixed in a <div> tag. > The fix here also uses a similar approach where every component is surrounded > by a <div> tag and the width is fixed for them so that the appear in their > respective positions regardless of the length of service names. I have also > adjusted the width of the left <div> component with "span8" instead of > "span7" and the right <div> component of the button to "span4" instead of > "span5" to better adjust the spacing. > > TESTS: > No tests are written for these changes as the fix involves updates in the > stylesheet. > However, the changes were tested by zooming in and out and checking if the > icons and names were contained in their respective blocks and not overlapping > with other <div> blocks. > > > The following is the result of running ambari-web tests: > > 24565 tests complete (28 seconds) > 145 tests pending > > > File Attachments > ---------------- > > AMBARI-15310 (patch-2) > > https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch > AMBARI-15310 (patch-3) > > https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch > AMBARI-15310 (patch-4) > > https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch > AMBARI-15310 (patch-5) > > https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch > > > Thanks, > > Keta Patel > >
