> On April 9, 2016, 4:04 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py,
> >  line 89
> > <https://reviews.apache.org/r/45972/diff/1/?file=1337941#file1337941line89>
> >
> >     Will this not always be true? What is the expected value of status to 
> > go in to the if condition

With the code shuffling as part of fix for 'Restart LLAP', status is not being 
returned from _start_llap and start() skips starting HSI. This is a stop gap 
thing till we add status check based on "service hive status" comamand.


> On April 9, 2016, 4:04 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py,
> >  line 183
> > <https://reviews.apache.org/r/45972/diff/1/?file=1337941#file1337941line183>
> >
> >     --loglevel is probably default set to INFO. Do we need to pass that in 
> > explicitly?

I am supposed to read these values from the config, and along with that add 
multiple other params that we are not adding as part of LLAP package creation. 
Will be fixed that time.


> On April 9, 2016, 4:04 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py,
> >  line 241
> > <https://reviews.apache.org/r/45972/diff/1/?file=1337941#file1337941line241>
> >
> >     On which host should these directories be created? It seems to be 
> > needed on all hosts where llap is running - at least based on the name.
> >     
> >     Also, we should be using the Directory construct to create the 
> > directories.

Will check with Sergey on this and use Directory  contruct.


> On April 9, 2016, 4:04 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml,
> >  line 477
> > <https://reviews.apache.org/r/45972/diff/1/?file=1337943#file1337943line477>
> >
> >     Change the default to /hadoop/llap/local

Ok.


- Swapan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/#review127987
-----------------------------------------------------------


On April 9, 2016, 9:33 p.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45972/
> -----------------------------------------------------------
> 
> (Updated April 9, 2016, 9:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15785
>     https://issues.apache.org/jira/browse/AMBARI-15785
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HiveServerInteractive. Kerberos Support. 
> 
> - Needs to have hive keytabs on all nodemanagers.
> - Hive Server Interactive needs same keytabs as HiveServer and Metastore.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  055296b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  c7d57c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  5830a52 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 9050092 
> 
> Diff: https://reviews.apache.org/r/45972/diff/
> 
> 
> Testing
> -------
> 
> - Partially done.
> - Python UT : PASSES.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to